Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Time a strong type #2150

Closed
nmm0 opened this issue May 16, 2023 · 0 comments · Fixed by #2151
Closed

Make Time a strong type #2150

nmm0 opened this issue May 16, 2023 · 0 comments · Fixed by #2151
Assignees
@JacobDomagala
Labels
type: refactor type: task

Comments

@nmm0
Copy link
Collaborator

nmm0 commented May 16, 2023

What Needs to be Done?
To avoid implicit conversions from ints/doubles, time should be a strong type.

See #2147 for a situation in which this came up
@JacobDomagala JacobDomagala self-assigned this May 22, 2023
@nmm0 nmm0 mentioned this issue May 23, 2023
Open
JacobDomagala added a commit that referenced this issue May 26, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
e918317
@JacobDomagala JacobDomagala mentioned this issue May 26, 2023
Merged
JacobDomagala added a commit that referenced this issue May 26, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
ce5047c
JacobDomagala added a commit that referenced this issue May 30, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
8972a7b
JacobDomagala added a commit that referenced this issue May 30, 2023
@JacobDomagala
#2150: LB: Remove BaseLB::loadMilli and use TimeType::milliseconds in…
fd7266b 
…stead
JacobDomagala added a commit that referenced this issue May 30, 2023
@JacobDomagala
#2150: LB: Remove BaseLB::loadMilli and use TimeType::milliseconds in…
f3f4f0c 
…stead
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
22faf0f
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
451d873
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
c7eb380 
…s() instead
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
8a8b807
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
034ca8c
JacobDomagala added a commit that referenced this issue Jun 6, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
0a13179 
…s() instead
@JacobDomagala JacobDomagala mentioned this issue Jun 15, 2023
Closed
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
2b12618
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
ea99fde
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
897fbef 
…s() instead
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
bb82ad7
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
390e6d6
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
ac0cfed 
…s() instead
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
d53aec4
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
b4b295c
JacobDomagala added a commit that referenced this issue Sep 20, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
ac1acda 
…s() instead
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
5342bd0
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
5c07be5
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
fc186b3
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
f1c89d3 
…s() instead
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
45c4b8e
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
13d917d
JacobDomagala added a commit that referenced this issue Sep 26, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
0a5bbad
JacobDomagala added a commit that referenced this issue Oct 6, 2023
@JacobDomagala
#2150: Types: Make Time a strong type and use it across the codebase
ba9cd6a
JacobDomagala added a commit that referenced this issue Oct 6, 2023
@JacobDomagala
#2150: Trace: Fix trace issues with new Time's type
b75e84f
JacobDomagala added a commit that referenced this issue Oct 6, 2023
@JacobDomagala
#2150: LB: Remove old toMilli function and use TimeType's millisecond…
0dbe9ed 
…s() instead
JacobDomagala added a commit that referenced this issue Oct 6, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
6ffda7b
JacobDomagala added a commit that referenced this issue Oct 6, 2023
@JacobDomagala
#2150: Resolve conflicts and compile issues
edd172e
lifflander added a commit that referenced this issue Oct 11, 2023
@lifflander
Merge pull request #2151 from DARMA-tasking/2150-use-strong-time-type
96f533a 
#2150: Types: Make `Time` a strong type and use it across the codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
type: refactor type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2150: Types: Make Time a strong type and use it across the codebase DARMA-tasking/vt
2 participants
@nmm0 @JacobDomagala