Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1912 1913 1915 performance optimizations 2 #1917

Closed
wants to merge 3 commits into from

Conversation

stmcgovern
Copy link
Contributor

Closes #1912.
Closes #1913.
Closes #1915.

Second PR of multiple for fine-grained performance enhancements.

@stmcgovern stmcgovern linked an issue Aug 16, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Aug 16, 2022

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-5, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 86e52ad

Compilation - successful

Testing - passed

Build log


@stmcgovern stmcgovern marked this pull request as ready for review August 16, 2022 16:07
@nlslatt
Copy link
Collaborator

nlslatt commented Aug 16, 2022

@stmcgovern The PR tests are not making progress because you marked this ready for review after your last push. If you resign the last commit and force push, the tests will run.

@stmcgovern
Copy link
Contributor Author

@nlslatt thank you

@stmcgovern stmcgovern force-pushed the 1912-1913-performance-optimizations-2 branch from 0ebf224 to e0e2b43 Compare August 16, 2022 18:55
@stmcgovern stmcgovern force-pushed the 1912-1913-performance-optimizations-2 branch from e0e2b43 to 86e52ad Compare August 16, 2022 21:46
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1917 (86e52ad) into develop (397dc80) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1917      +/-   ##
===========================================
- Coverage    84.39%   84.37%   -0.02%     
===========================================
  Files          761      761              
  Lines        26866    26866              
===========================================
- Hits         22673    22669       -4     
- Misses        4193     4197       +4     
Impacted Files Coverage Δ
src/vt/pool/static_sized/memory_pool_equal.h 100.00% <ø> (ø)
src/vt/messaging/envelope/envelope_ref.impl.h 100.00% <100.00%> (+14.28%) ⬆️
src/vt/pool/static_sized/memory_pool_equal.cc 100.00% <100.00%> (ø)
src/vt/runtime/runtime.cc 75.58% <100.00%> (-0.06%) ⬇️
src/vt/vrt/collection/manager.impl.h 95.49% <0.00%> (-0.99%) ⬇️
src/vt/phase/phase_manager.cc 92.56% <0.00%> (+1.35%) ⬆️

@PhilMiller
Copy link
Member

Stand-alone PRs would be preferable, again for better traceability

@stmcgovern
Copy link
Contributor Author

Split into PR #1927, #1928 and #1929.

@stmcgovern stmcgovern closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants