Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1912 Use assert to optimize production path check #1927

Conversation

stmcgovern
Copy link
Contributor

Closes #1912.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Pipelines results

PR tests (clang-5.0, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-5, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for 77d1a97

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for f47c15a

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1927 (f47c15a) into develop (204c403) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1927   +/-   ##
========================================
  Coverage    84.40%   84.40%           
========================================
  Files          761      761           
  Lines        26869    26868    -1     
========================================
  Hits         22678    22678           
+ Misses        4191     4190    -1     
Impacted Files Coverage Δ
src/vt/messaging/envelope/envelope_ref.impl.h 100.00% <100.00%> (+14.28%) ⬆️

@PhilMiller PhilMiller force-pushed the 1912-dont-error-check-reference-count-deref-on-envelope-in-production branch from 41213c7 to 77d1a97 Compare August 24, 2022 00:04
@PhilMiller
Copy link
Member

I'll let CI finish rerunning before I fix the signature on the rebase, so that the caches can stay hot

@PhilMiller PhilMiller force-pushed the 1912-dont-error-check-reference-count-deref-on-envelope-in-production branch from 77d1a97 to f47c15a Compare August 30, 2022 22:49
@PhilMiller PhilMiller merged commit 7c0a83c into develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't error check reference count deref on envelope in production
3 participants