Enable ReflectionResolver to resolve map keys #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to do more complex operations, `CustomPlaceholderResolver` is refactored to also receive the bean of the resolver
To be able to do more complex operations, `CustomPlaceholderResolver` is refactored to also receive the bean of the resolver
To be able to use the util functions in packages utilizing jocument, the methods to figure out the type and the dimensions of a picture have been made public.
Also fix usage of deprecated flag
If we have a custom placeholder, which is a set, jocument would attempt to unroll it before it does the custom placeholder resolving
…nResolver Before falling back on the mappings for reflection placeholders we first probe if the placeholder name can be directly accessed. If so, we resolve it right away, otherwise we fallback.
…o feature/placeholder-mapping # Conflicts: # build.gradle # src/main/java/com/docutools/jocument/PlaceholderMapper.java # src/main/java/com/docutools/jocument/impl/FutureReflectionResolver.java # src/main/java/com/docutools/jocument/impl/PlaceholderMapperImpl.java # src/main/java/com/docutools/jocument/impl/ReflectionResolver.java
…nResolver Before falling back on the mappings for reflection placeholders we first probe if the placeholder name can be directly accessed. If so, we resolve it right away, otherwise we fallback.
* Remove incorrect logging statement in `TemplateImpl` * Close document in finally in `ExcelDocumentImpl` * Use `@Image` annotation for test case * Cleanup `TemplateLoading.java`
…Ex Placeholder Matching The MatcherPlaceholder-Annotation Allows to define a regular expression pattern for a method to be resolved in a ReflectionResolver if the placeholder name passed to `ReflectionResolver#resolve(String, Locale)` matches against the pattern.
Issues with deployment of .16.
This commit adds the functionality s.t. `ReflectionResolver` can resolve placeholders referencing map keys.
AntonOellerer
changed the title
AntonOellerer
changed the title
AntonOellerer
changed the title
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
61a3f13 to
a2f4003
Compare
|
not needed for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the functionality s.t. the jocument can resolve placeholders referencing map keys.
It has been integrated into the reflection-based resolvers
Related to https://app.shortcut.com/ddsg/story/4792/implement-dataset-block-for-xlsx-reports