Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ReflectionResolver to resolve map keys #138

Closed
wants to merge 55 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
3dd1b8a
Implement placeholder replacement via mapping
AntonOellerer Dec 16, 2021
f6bbbae
Implemenent future handling
AntonOellerer Dec 16, 2021
bcc6ec6
Refactoring
AntonOellerer Dec 21, 2021
a5bba8a
Refactor to set mapping path dynamically
AntonOellerer Dec 21, 2021
f36aeea
Refactor and add tests
AntonOellerer Dec 21, 2021
e22f758
Update `CustomPlaceholderResolver` to receive bean
AntonOellerer Dec 21, 2021
fad45df
Implement placeholder replacement via mapping
AntonOellerer Dec 16, 2021
943cf62
Implemenent future handling
AntonOellerer Dec 16, 2021
0f33d08
Refactoring
AntonOellerer Dec 21, 2021
7a39e3e
Refactor to set mapping path dynamically
AntonOellerer Dec 21, 2021
706516e
Refactor and add tests
AntonOellerer Dec 21, 2021
fca769d
Update `CustomPlaceholderResolver` to receive bean
AntonOellerer Dec 21, 2021
672e2d8
Add dimension parameter for inserting images
AntonOellerer Jan 28, 2022
95b2cb5
Extend image type probing to all supported by poi
AntonOellerer Jan 31, 2022
192fa3a
Make necessary `WordImageUtils` methods public
AntonOellerer Feb 1, 2022
78fdd26
Make `ImageStrategy INSTANCE` volatile
AntonOellerer Feb 1, 2022
dc64a17
Upgrade to gradle 7.3.3
AntonOellerer Feb 1, 2022
09170d2
Ign. case on fetching object field by placeholder
AntonOellerer Feb 15, 2022
c97a7eb
Check if custom placeholder before loop
AntonOellerer Feb 15, 2022
bebd13f
Improve logging
AntonOellerer Feb 15, 2022
1ba5665
Improve logging
AntonOellerer Feb 15, 2022
6af75b9
Add timout parameter to FutureReflectionResolver
AntonOellerer Feb 16, 2022
794119e
Prioritize directly accessible Resolved over Mapped ones in Reflectio…
alexpartsch Feb 16, 2022
2611bf8
Merge remote-tracking branch 'origin/feature/placeholder-mapping' int…
alexpartsch Feb 16, 2022
59e3fc0
Prioritize directly accessible Resolved over Mapped ones in Reflectio…
alexpartsch Feb 16, 2022
fa531e1
Fix naming of temporary files
AntonOellerer Feb 21, 2022
33df97c
Ignore case when retrieving record field
AntonOellerer Feb 21, 2022
3773f95
Add MatchPlaceholder-Annotation for ReflectionResolver to support Reg…
alexpartsch Mar 1, 2022
dad566b
Bump Version to 1.4.0-alpha.16
alexpartsch Mar 1, 2022
64770fe
Bump Version to 1.4.0-alpha.17
alexpartsch Mar 1, 2022
6a3958a
Add concept of Parent to ReflectionResolver
alexpartsch Mar 7, 2022
fd576b4
Bump Version to 1.4.0-alpha.18
alexpartsch Mar 11, 2022
d13995a
Bump Version to 1.4.0-alpha.20
alexpartsch Mar 11, 2022
202dcfe
Add test for case-insensitive matching
AntonOellerer Mar 15, 2022
d788e81
WIP Introduce Conditional Placeholders
alexpartsch Mar 15, 2022
a8a637e
Clean up conditional resolving
AntonOellerer Mar 15, 2022
5ae6dde
Clean up conditional resolving
AntonOellerer Mar 15, 2022
5735d42
Enable `end-` as additional block end statement
AntonOellerer Mar 15, 2022
8cf4d89
Merge branch 'feature/placeholder-mapping' of github.com:DDS-GmbH/joc…
alexpartsch Mar 17, 2022
2187faf
Add Abstraction Layer in PlaceholderResolver#resolve
alexpartsch Mar 17, 2022
e78a0c1
Allow to Register Custom Formatters for ScalarPlaceholderData before …
alexpartsch Mar 17, 2022
8874ca0
Pass Locale down the PlaceholderData#transform Method
alexpartsch Mar 17, 2022
83e0226
Bump Version
alexpartsch Mar 17, 2022
03705ec
Pass GenerationOptions down to Children
alexpartsch Mar 21, 2022
9be5e0c
Pass GenerationOptions down to Children in FutureReflectionResolver
alexpartsch Mar 21, 2022
9c316d6
Allow to pass a Translations Function to GenerationOptions
alexpartsch Mar 22, 2022
ae20b83
Bump Version
alexpartsch Mar 22, 2022
0d27dcb
Enable ReflectionResolver to resolve map keys
AntonOellerer Apr 13, 2022
090b918
Use separate `MapResolver` for map resolving
AntonOellerer Apr 13, 2022
8ebdf8a
Refactorings
AntonOellerer Apr 13, 2022
626e80b
Bump version
AntonOellerer Apr 14, 2022
61d6ea0
Bump Version to 1.4.0-alpha.27
alexpartsch May 18, 2022
5af0d1c
Bump Version to 1.4.0-alpha.28
alexpartsch May 18, 2022
d68d7e7
Bump Version to 1.4.0-alpha.29
alexpartsch May 18, 2022
a11e2a3
Bump Version to 1.4.0-alpha.34
alexpartsch May 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ plugins {
}

group 'com.docutools'
version = '1.3.2'
version = '1.4.0-alpha.34'

sourceCompatibility = 17
targetCompatibility = 17
sourceCompatibility = "17"
targetCompatibility = "17"

repositories {
mavenCentral()
Expand All @@ -35,6 +35,7 @@ dependencies {

implementation("com.google.code.gson:gson:2.8.9")
implementation("org.apache.tika:tika-core:2.2.1")
implementation("org.apache.commons:commons-lang3:3.12.0")

runtimeOnly group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.17.1'
implementation group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.17.1'
Expand Down Expand Up @@ -75,6 +76,7 @@ test {
}

task automatedTests(type: Test) {
environment 'DT_JT_RR_PLACEHOLDER_MAPPINGS', 'src/test/resources/mappings.txt'
useJUnitPlatform{
includeTags "automated"
}
Expand All @@ -86,8 +88,8 @@ publishing {
name = "GitHubPackages"
url = uri("https://maven.pkg.github.com/DDS-GmbH/jocument")
credentials {
username = project.findProperty("gpr.user") ?: System.getenv("GITHUB_USERNAME")
password = project.findProperty("gpr.token") ?: System.getenv("GITHUB_TOKEN")
username = project.findProperty("gpr.gh.user") ?: System.getenv("GITHUB_USERNAME")
password = project.findProperty("gpr.gh.token") ?: System.getenv("GITHUB_TOKEN")
}
}
}
Expand Down Expand Up @@ -119,6 +121,6 @@ task jacocoAutomatedTestReport(type: JacocoReport) {
sourceSets sourceSets.main
executionData automatedTests
reports {
xml.enabled true
xml.getRequired().set(true)
}
}
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
257 changes: 153 additions & 104 deletions gradlew
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env sh
#!/bin/sh

#
# Copyright 2015 the original author or authors.
# Copyright © 2015-2021 the original authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -17,67 +17,101 @@
#

##############################################################################
##
## Gradle start up script for UN*X
##
#
# Gradle start up script for POSIX generated by Gradle.
#
# Important for running:
#
# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is
# noncompliant, but you have some other compliant shell such as ksh or
# bash, then to run this script, type that shell name before the whole
# command line, like:
#
# ksh Gradle
#
# Busybox and similar reduced shells will NOT work, because this script
# requires all of these POSIX shell features:
# * functions;
# * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
# «${var#prefix}», «${var%suffix}», and «$( cmd )»;
# * compound commands having a testable exit status, especially «case»;
# * various built-in commands including «command», «set», and «ulimit».
#
# Important for patching:
#
# (2) This script targets any POSIX shell, so it avoids extensions provided
# by Bash, Ksh, etc; in particular arrays are avoided.
#
# The "traditional" practice of packing multiple parameters into a
# space-separated string is a well documented source of bugs and security
# problems, so this is (mostly) avoided, by progressively accumulating
# options in "$@", and eventually passing that to Java.
#
# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS,
# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly;
# see the in-line comments for details.
#
# There are tweaks for specific operating systems such as AIX, CygWin,
# Darwin, MinGW, and NonStop.
#
# (3) This script is generated from the Groovy template
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# within the Gradle project.
#
# You can find Gradle at https://github.com/gradle/gradle/.
#
##############################################################################

# Attempt to set APP_HOME

# Resolve links: $0 may be a link
PRG="$0"
# Need this for relative symlinks.
while [ -h "$PRG" ] ; do
ls=`ls -ld "$PRG"`
link=`expr "$ls" : '.*-> \(.*\)$'`
if expr "$link" : '/.*' > /dev/null; then
PRG="$link"
else
PRG=`dirname "$PRG"`"/$link"
fi
app_path=$0

# Need this for daisy-chained symlinks.
while
APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path
[ -h "$app_path" ]
do
ls=$( ls -ld "$app_path" )
link=${ls#*' -> '}
case $link in #(
/*) app_path=$link ;; #(
*) app_path=$APP_HOME$link ;;
esac
done
SAVED="`pwd`"
cd "`dirname \"$PRG\"`/" >/dev/null
APP_HOME="`pwd -P`"
cd "$SAVED" >/dev/null

APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="Gradle"
APP_BASE_NAME=`basename "$0"`
APP_BASE_NAME=${0##*/}

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'

# Use the maximum available, or set MAX_FD != -1 to use that value.
MAX_FD="maximum"
MAX_FD=maximum

warn () {
echo "$*"
}
} >&2

die () {
echo
echo "$*"
echo
exit 1
}
} >&2

# OS specific support (must be 'true' or 'false').
cygwin=false
msys=false
darwin=false
nonstop=false
case "`uname`" in
CYGWIN* )
cygwin=true
;;
Darwin* )
darwin=true
;;
MINGW* )
msys=true
;;
NONSTOP* )
nonstop=true
;;
case "$( uname )" in #(
CYGWIN* ) cygwin=true ;; #(
Darwin* ) darwin=true ;; #(
MSYS* | MINGW* ) msys=true ;; #(
NONSTOP* ) nonstop=true ;;
esac

CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
Expand All @@ -87,9 +121,9 @@ CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
if [ -n "$JAVA_HOME" ] ; then
if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
# IBM's JDK on AIX uses strange locations for the executables
JAVACMD="$JAVA_HOME/jre/sh/java"
JAVACMD=$JAVA_HOME/jre/sh/java
else
JAVACMD="$JAVA_HOME/bin/java"
JAVACMD=$JAVA_HOME/bin/java
fi
if [ ! -x "$JAVACMD" ] ; then
die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME
Expand All @@ -98,88 +132,103 @@ Please set the JAVA_HOME variable in your environment to match the
location of your Java installation."
fi
else
JAVACMD="java"
JAVACMD=java
which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation."
fi

# Increase the maximum file descriptors if we can.
if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then
MAX_FD_LIMIT=`ulimit -H -n`
if [ $? -eq 0 ] ; then
if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then
MAX_FD="$MAX_FD_LIMIT"
fi
ulimit -n $MAX_FD
if [ $? -ne 0 ] ; then
warn "Could not set maximum file descriptor limit: $MAX_FD"
fi
else
warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT"
fi
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
MAX_FD=$( ulimit -H -n ) ||
warn "Could not query maximum file descriptor limit"
esac
case $MAX_FD in #(
'' | soft) :;; #(
*)
ulimit -n "$MAX_FD" ||
warn "Could not set maximum file descriptor limit to $MAX_FD"
esac
fi

# For Darwin, add options to specify how the application appears in the dock
if $darwin; then
GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\""
fi
# Collect all arguments for the java command, stacking in reverse order:
# * args from the command line
# * the main class name
# * -classpath
# * -D...appname settings
# * --module-path (only if needed)
# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables.

# For Cygwin or MSYS, switch paths to Windows format before running java
if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
APP_HOME=`cygpath --path --mixed "$APP_HOME"`
CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`

JAVACMD=`cygpath --unix "$JAVACMD"`

# We build the pattern for arguments to be converted via cygpath
ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null`
SEP=""
for dir in $ROOTDIRSRAW ; do
ROOTDIRS="$ROOTDIRS$SEP$dir"
SEP="|"
done
OURCYGPATTERN="(^($ROOTDIRS))"
# Add a user-defined pattern to the cygpath arguments
if [ "$GRADLE_CYGPATTERN" != "" ] ; then
OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)"
fi
if "$cygwin" || "$msys" ; then
APP_HOME=$( cygpath --path --mixed "$APP_HOME" )
CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" )

JAVACMD=$( cygpath --unix "$JAVACMD" )

# Now convert the arguments - kludge to limit ourselves to /bin/sh
i=0
for arg in "$@" ; do
CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -`
CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option

if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition
eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"`
else
eval `echo args$i`="\"$arg\""
for arg do
if
case $arg in #(
-*) false ;; # don't mess with options #(
/?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath
[ -e "$t" ] ;; #(
*) false ;;
esac
then
arg=$( cygpath --path --ignore --mixed "$arg" )
fi
i=`expr $i + 1`
# Roll the args list around exactly as many times as the number of
# args, so each arg winds up back in the position where it started, but
# possibly modified.
#
# NB: a `for` loop captures its iteration list before it begins, so
# changing the positional parameters here affects neither the number of
# iterations, nor the values presented in `arg`.
shift # remove old arg
set -- "$@" "$arg" # push replacement arg
done
case $i in
0) set -- ;;
1) set -- "$args0" ;;
2) set -- "$args0" "$args1" ;;
3) set -- "$args0" "$args1" "$args2" ;;
4) set -- "$args0" "$args1" "$args2" "$args3" ;;
5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
esac
fi

# Escape application args
save () {
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
echo " "
}
APP_ARGS=`save "$@"`
# Collect all arguments for the java command;
# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
# shell script including quotes and variable substitutions, so put them in
# double quotes to make sure that they get re-expanded; and
# * put everything else in single quotes, so that it's not re-expanded.

set -- \
"-Dorg.gradle.appname=$APP_BASE_NAME" \
-classpath "$CLASSPATH" \
org.gradle.wrapper.GradleWrapperMain \
"$@"

# Use "xargs" to parse quoted args.
#
# With -n1 it outputs one arg per line, with the quotes and backslashes removed.
#
# In Bash we could simply go:
#
# readarray ARGS < <( xargs -n1 <<<"$var" ) &&
# set -- "${ARGS[@]}" "$@"
#
# but POSIX shell has neither arrays nor command substitution, so instead we
# post-process each arg (as a line of input to sed) to backslash-escape any
# character that might be a shell metacharacter, then use eval to reverse
# that process (while maintaining the separation between arguments), and wrap
# the whole thing up as a single "set" statement.
#
# This will of course break if any of these variables contains a newline or
# an unmatched quote.
#

# Collect all arguments for the java command, following the shell quoting and substitution rules
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
eval "set -- $(
printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" |
xargs -n1 |
sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' |
tr '\n' ' '
)" '"$@"'

exec "$JAVACMD" "$@"
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
public interface CustomPlaceholderRegistry {
void addHandler(String placeholder, Class<? extends CustomWordPlaceholderData> customWordPlaceholderDataClass);

Optional<PlaceholderData> resolve(String placeholder)
Optional<PlaceholderData> resolve(String placeholder, Object object)
throws NoSuchMethodException, IllegalAccessException, InvocationTargetException, InstantiationException;

boolean governs(String placeholderName);
boolean governs(String placeholderName, Object object);
}
Loading