Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump selenium-webdriver from 4.10.0 to 4.12.0 #8425

Closed
wants to merge 9 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2023

Bumps selenium-webdriver from 4.10.0 to 4.11.0.

Release notes

Sourced from selenium-webdriver's releases.

Selenium 4.11.0

Changelog

For each component's detailed changelog, please check:

Commits in this release

  • 8b02c886cf - [rb] Bumping Selenium version :: Diego Molina
  • 0f2e1b1f25 - Fix docstring for removed arg (browser_profile) (#12174) :: Michael Mintz
  • cbaff758e2 - [dotnet] Improving .NET API docs :: Diego Molina
  • 85a0c67c64 - [dotnet] Leaving .NET API docs at root level :: Diego Molina
  • e45195e0ab - [dotnet] Updating DevTools tests to use CDP 114 :: Diego Molina
  • e55129e8e6 - Update mirror info (Thu Jun 8 00:17:05 UTC 2023) :: Selenium CI Bot
  • 3084d2b6b3 - [dotnet] Updating DevTools tests to use CDP 114 (2) :: Diego Molina
  • cc3b395887 - [rb] Updating year in Ruby docs :: Diego Molina
  • 8ace4ecca4 - [py] Adding draft configuration for ReadTheDocs :: Diego Molina
  • 38802986d2 - [py] Fixing path for docs conf :: Diego Molina
  • da3a82b46b - [java] Add Missing W3C Exceptions (#12175) :: Oscar Devora
  • fbb0996e45 - [py] Improving docs landing page. :: Diego Molina
  • 043bb18a9e - [dotnet] Implementation of event wrapped shadow root element (#12073) :: Nikolay Borisenko
  • ca9d41a0d5 - [py] removed redundant attributes capabilities and set_capability in wpewebkit/options.py (#12169) :: Sandeep Suryaprasad
  • a50bfe29a1 - [js][bidi] fix addPreloadScript failing tests (#12182) :: Tamsil Sajid Amani
  • 3dc8903766 - [py] instance attributes in Timeout class are now being set through setter… (#12186) :: Sandeep Suryaprasad
  • 505abc310f - [java] Drop the prefix created by Bazel (#12173) :: joerg1985
  • 7cfd137085 - [js] fix SeleniumServer.start() crashes on MacOS with nodejs selenium-webdriver (#12158) :: Hanbo Wang
  • 2ebfcd93ea - [py] mapped all error codes in errorhandler.py to corresponding exception object. (#12190) :: Sandeep Suryaprasad
  • 94e6fdf11d - Bump cryptography from 39.0.1 to 41.0.0 in /py (#12130) :: dependabot[bot]
  • 79e6378d27 - [dotnet] Include generation of support project (#12193) :: Nikolay Borisenko
  • cdfba2b1c9 - [JS] Update rules_nodejs to 5.8.3 :: Sriharsha
  • 4d70bd80f4 - [py] add more shortcuts to webdriver ini file (#12194) :: Titus Fortner
  • d1f1b6fa39 - [py] Fix BrowserError issues (#12150) :: Sebastian Meyer
  • ebb232fd03 - Run format.sh script :: Simon Mavi Stewart
  • 25dbacb014 - [js][bidi] add Network module events (#12197) :: Tamsil Sajid Amani
  • ab6e4f894d - [py] improve driver logging (#12103) :: Titus Fortner
  • 265e2f4202 - [java] Increased the max depth of new session payload (#12205) :: joerg1985
  • c3b226cebf - [rust] Use CfT endpoints to discover chromedriver 115+ (#12208) :: Boni García
  • eb2321327e - [java] Applying again changes from SeleniumHQ/selenium@5c891ce :: Diego Molina
  • bf389143bf - [rust] Read browser_ttl and driver_ttl from CLI flags :: Boni Garcia
  • 7b9cb37648 - [java] Reading m2 user & pass from env vars where available :: Diego Molina
  • fc58eac32a - [java] Bumping to 4.11.0-SNAPSHOT :: Diego Molina
  • ad8921b59c - Adding Java to the nightly job :: Diego Molina

... (truncated)

Changelog

Sourced from selenium-webdriver's changelog.

4.11.0 (2023-07-31)

Ruby:

  • Made network interception threads fail silently (#12226)
  • Have Selenium Manager binary locate drivers on PATH (#12345)
  • Add browser output from selenium manager to options (#12398)
  • Remove deprecated code (#12417) BiDi:
  • Released selenium-devtools 0.115.0 (supports CDP v85, v113, v114, v115) Edge:
  • Adding ignore process match for IE Mode across bindings (#12279)
Commits
  • 5f77934 Updating change logs for 4.11.0
  • f3ab202 [rb] skip options with nil value
  • 5e39f36 [rb] redundant — asserting executable also asserts file
  • 0fa6c3f [rb] remove deprecated code (#12417)
  • 9fdeaa9 [rb] add browser output from selenium manager to options (#12398)
  • 2879d3e [cdp] add support for Chrome 115 and remove support for Chrome 112
  • 388f530 [rb] no longer need to require net/https separately
  • 0f5acf2 do not need an extra log message that manager is being used
  • 054467a [rb] have Selenium Manager binary locate drivers on PATH (#12345)
  • 2012243 [rb] Made network interception threads fail silently (#12226)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file Ruby Pull requests that update Ruby code labels Aug 1, 2023
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 1, 2023 02:59 Destroyed
@inulty-dfe inulty-dfe temporarily deployed to review_aks August 1, 2023 11:06 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 1, 2023 11:06 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 1, 2023 11:24 Destroyed
@inulty-dfe inulty-dfe temporarily deployed to review_aks August 1, 2023 12:39 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 1, 2023 13:06 Destroyed
@inulty-dfe
Copy link
Collaborator

I'm not sure how to proceed with this.

Original failures in the test suite related to the deprecation of the capabilities option in Selenium::Driver
https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/5721938268/job/15504368248
After passing the Options object directly to the driver initializer with the option: key, a new set of errors were caused.

New errors in test run:

Selenium::WebDriver::Error::UnknownError:
       unknown error: Chrome failed to start: exited abnormally.
         (unknown error: DevToolsActivePort file doesn't exist)
         (The process started from chrome location /github/home/.cache/selenium/chrome/linux[64](https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/5725923826/job/15515518052#step:6:65)/115.0.5790.102/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

These warnings began to appear in the test logging too:

2022-10-12 09:00:00 WARN Selenium [:selenium_manager] The chromedriver version (102.0.5005.182) detected in PATH at /usr/bin/chromedriver might not be compatible with the detected chrome version (115.0.5790.102); currently, chromedriver 115.0.5790.102 is recommended for chrome 115.*, so it is advised to delete the driver in PATH and retry

Something called selenium-manager has been added to selenium which takes responsibility for installing webdrivers. I don't understand exactly how this works and I don't have enough access to the image that is built by GitHub actions to interrogate.

I removed installing chromium from GH actions but that was probably too extreme.

The alpine linux image installs chromium v 102, the latest release is 115. I wonder if this is related.

Changes in selenium project:
SeleniumHQ/selenium#12417

For now I'll drop this upgrade, it's not critical.

@inulty-dfe inulty-dfe temporarily deployed to review_aks August 1, 2023 14:22 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 1, 2023 14:23 Destroyed
@zarembas
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 13, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@zarembas zarembas force-pushed the dependabot/bundler/selenium-webdriver-4.11.0 branch from 980a4fa to 01d4fea Compare August 14, 2023 09:02
@zarembas zarembas temporarily deployed to review_aks August 14, 2023 09:09 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 14, 2023 09:09 Destroyed
@zarembas zarembas temporarily deployed to review_aks August 14, 2023 09:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 14, 2023 09:32 Destroyed
@zarembas zarembas temporarily deployed to review_aks August 14, 2023 10:02 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 August 14, 2023 10:03 Destroyed
@zarembas
Copy link
Contributor

Can't figure out how to solve this. We might want to lock the version to 4.10.0 for now.
This is related to not having chromedriver published here: https://chromedriver.chromium.org/downloads but here instead: https://googlechromelabs.github.io/chrome-for-testing/ after the release of Chrome for Testing.

Related issue: titusfortner/webdrivers#247

A possible solution would be to download chromedriver 115, but it does seem like Chrome for testing should be doing this automatically.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 1, 2023

A newer version of selenium-webdriver exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@zarembas zarembas force-pushed the dependabot/bundler/selenium-webdriver-4.11.0 branch from 5eda9dd to c3dab64 Compare September 1, 2023 14:53
@zarembas zarembas temporarily deployed to review_aks September 1, 2023 14:58 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 September 1, 2023 14:58 Destroyed
@zarembas zarembas temporarily deployed to review_aks September 1, 2023 15:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 September 1, 2023 15:15 Destroyed
@zarembas zarembas temporarily deployed to review_aks September 1, 2023 15:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 September 1, 2023 15:37 Destroyed
@zarembas zarembas changed the title Bump selenium-webdriver from 4.10.0 to 4.11.0 Bump selenium-webdriver from 4.10.0 to 4.12.0 Sep 1, 2023
@zarembas zarembas temporarily deployed to review_aks September 1, 2023 16:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 September 1, 2023 16:57 Destroyed
@zarembas zarembas force-pushed the dependabot/bundler/selenium-webdriver-4.11.0 branch from 6eb66b0 to bbaf0cb Compare September 1, 2023 17:15
@zarembas zarembas temporarily deployed to review_aks September 1, 2023 17:23 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8425 September 1, 2023 17:23 Destroyed
@JR-G JR-G closed this Sep 12, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 12, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@JR-G JR-G temporarily deployed to review_aks September 12, 2023 19:53 — with GitHub Actions Inactive
@dependabot dependabot bot deleted the dependabot/bundler/selenium-webdriver-4.11.0 branch September 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked dependencies Pull requests that update a dependency file Ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants