[rb] remove deprecated code #12417
Merged
[rb] remove deprecated code #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0deje
approved these changes
Jul 25, 2023
|
FYI (for anyone getting here later) this is a breaking change for using selenium for IE testing, oops. |
|
Yes, we only deprecate for breaking changes, so removing a deprecation is always a breaking change. |
robinjam
added a commit
to alphagov/smokey
that referenced
this pull request
Oct 12, 2023
robinjam
added a commit
to alphagov/smokey
that referenced
this pull request
Oct 12, 2023
Context for changes: - https://www.selenium.dev/blog/2023/headless-is-going-away/ - SeleniumHQ/selenium#12417 We must use `--headless` instead of `--headless=new` because the latter causes chromedriver to crash when running within Docker (for some reason 🤷)
robinjam
added a commit
to alphagov/smokey
that referenced
this pull request
Oct 12, 2023
Context for changes: - https://www.selenium.dev/blog/2023/headless-is-going-away/ - SeleniumHQ/selenium#12417 We must use `--headless` instead of `--headless=new` because the latter causes chromedriver to crash when running within Docker (for some reason 🤷)
sue445
added a commit
to sue445/apple_system_status
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#headless!methodsService#driver_optscode; a poorly conceived idea to convert key/value pairs into argsRemote::Capabilities. Want to encourage people to move toOptionsas much as possible. (next release we remove ability for users to pass Capabilities instance to local drivers)Motivation and Context
This is everything that was deprecated for Selenium 4.8 in January 2023.
Removes a lot of extra code.