deal with directory separators cleanly #5360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfhack assumes that scripts are in a namespace in which directories are separated by slashes, and also that pathnames will be slash-separated this enforces that when the transition is made from a `std::filesystem::path` to dfhack's internal script name space, backslashes are replaced with slashes on systems where the preferred separator is not already '/'
myk002
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfhack assumes that scripts are in a namespace in which directories are separated by slashes, and also that pathnames will be slash-separated
this enforces that when the transition is made from a
std::filesystem::pathto dfhack's internal script name space, the native preferred path separator (whatever it is) is replaced with slashes if it isn't alreadyfollowup to #5356