more path/string normalization #5361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added `Filesystem::as_string` to provide namespace recanonicalization and change use in LuaApi to use this exported API use `as_string` in `orders`
myk002
reviewed
Mar 23, 2025
| continue; // skip non-.json files | ||
| auto sname = name.stem(); | ||
| out << "library/" << sname << std::endl; | ||
| out << Filesystem::as_string("library" / sname) << std::endl; |
Member
There was a problem hiding this comment.
The documented names of the library orders sets use the forward slash. Will this preserve that? Same for stockpiles, blueprint, quickfort, and other tools that come with libraries
Member
Author
There was a problem hiding this comment.
this only transforms names that are transformed from pathnames enumerated by listdir_recursive. input from other sources is completely unaffected
myk002
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
Filesystem::as_stringto provide namespace recanonicalization and change use in LuaApi to use this exported APIuse
as_stringinordersfurther revision of #5360