Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automated tests for Frontend Electron app #64

Closed
natalialuzuriaga opened this issue Jun 20, 2024 · 9 comments
Closed

Create automated tests for Frontend Electron app #64

natalialuzuriaga opened this issue Jun 20, 2024 · 9 comments
Assignees
Labels
dedupliFHIR DedupliFHIR repo tickets enhancement New feature or request summer2024 Tickets for Summer 2024 Fellowship Cohort

Comments

@natalialuzuriaga
Copy link
Collaborator

natalialuzuriaga commented Jun 20, 2024

Is your feature request related to a problem? Please describe.
Currently, there are no tests written for the frontend electron.js desktop app.

Describe the intended behavior
As part of development and release, we would like to run end-to-end automated tests for desktop app.

Describe the solution you'd like
A suite of tests should be written to test the functionality of the desktop app. Include the tests as part of making releases and in our PR reviews

Describe alternatives you've considered
Manual testing is being done at the moment.

Additional Information:

@natalialuzuriaga natalialuzuriaga added enhancement New feature or request dedupliFHIR DedupliFHIR repo tickets summer2024 Tickets for Summer 2024 Fellowship Cohort labels Jun 20, 2024
@natalialuzuriaga natalialuzuriaga changed the title Create tests for Frontend Electron app Create automated tests for Frontend Electron app Jun 20, 2024
@Firebird1029
Copy link
Member

@IsaacMilarky I saw you created a PR related to this, does this make this ticket obsolete? If not, I was going to take a look at it next!

@IsaacMilarky
Copy link
Collaborator

@IsaacMilarky I saw you created a PR related to this, does this make this ticket obsolete? If not, I was going to take a look at it next!

There are currently backend Python tests that are pending a PR merge but this ticket is for developing tests for the Electron frontend. This ticket is specifically for frontend tests. It would be amazing if you wanted to write tests for the electron.js frontend that would be a great feature to have.

@Firebird1029

@Firebird1029 Firebird1029 self-assigned this Jun 21, 2024
@IsaacMilarky
Copy link
Collaborator

IsaacMilarky commented Jun 28, 2024

6/28:

  • Still a WIP
  • Just hardcoded Python Path to ignore bug that was found
  • Found bug in frontend not being able to find Python if Anaconda was installed on the system
  • ACTION: File a ticket and fix the bug in the frontend

@IsaacMilarky
Copy link
Collaborator

7/1:

  • Started writing tests
  • Started with basic checks
  • ACTION: file ticket
  • Going to use Playwright bc of its GH stars

@Firebird1029
Copy link
Member

WIP PR: #69
PR still needs to clarify download file system window, and add Github Action script
new issue opened: #70
when viewport height is too low, Submit button is not clickable

@IsaacMilarky
Copy link
Collaborator

7/8:

  • Wrote frontend tests
  • Checking for file download not possible because it is handled by the OS
  • ACTION: continue to work on draft PR and finish tests

@Firebird1029
Copy link
Member

Github Action script steps for future reference:

      - name: Install dependencies for tests
        run: npx playwright install --with-deps chromium

      - name: Run frontend tests
        run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm test

@Firebird1029
Copy link
Member

Restarted PR: #71

@IsaacMilarky
Copy link
Collaborator

7/12:

  • PR was merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dedupliFHIR DedupliFHIR repo tickets enhancement New feature or request summer2024 Tickets for Summer 2024 Fellowship Cohort
Development

No branches or pull requests

3 participants