Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend tests #69

Closed
wants to merge 20 commits into from
Closed

Add frontend tests #69

wants to merge 20 commits into from

Conversation

Firebird1029
Copy link
Member

Add frontend tests

Problem

Currently, the Electron app frontend lacks frontend tests.

Solution

This PR adds some frontend tests to ensure the Electron app works correctly.

Result

To run the tests:

cd frontend
npx playwright test

@Firebird1029 Firebird1029 mentioned this pull request Jul 8, 2024
Closed
Firebird1029 and others added 20 commits July 8, 2024 16:17
@Firebird1029
add Playwright and basic tests
63aa08b 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
Fix parsing wrong data and create new constant
f1bd0de 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
add more frontend tests
b197bd0 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
add frontend tests to Github Action workflow
a57a241 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
fix Github Action script 1
c987bea 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
change test data path and increase timeout
283ec58 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
remove redundant awaits
cfb96db 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
fix Github Action script 2
e17ed61 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
write a suite of tests for dedupliFHIR
635eb25 
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
test the tests
8966412 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
Formatting changes
3b3f0fc 
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
fix test
bbb8d85 
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
rewrite tests to use the click cli interface and test the cli directly
419b2e7 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
Move tests to their own directory
92b132c 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
add more tests
16f3179 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
linting
4f43df0 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
Update checks to correct tests location
c2aa1d1 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
fix invoke of pytest
2e421a3 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@IsaacMilarky @Firebird1029
remove unneeded imports
1207d89 
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
@Firebird1029
remove frontend tests
3095661 
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Jul 8, 2024
View reviewed changes
cli/deduplifhirLib/tests/main_test.py
Test dedupe_data function with specific CSV data to verify deduplication.
"""
# Prepare test data
test_data_csv = """id,truth_value,family_name,given_name,gender,birth_date,phone,street_address,city,state,postal_code,SSN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0301: Line too long (126/100) (line-too-long)

cli/deduplifhirLib/tests/main_test.py
Test dedupe_data function for deduplication accuracy using a dataset with known duplicates.
"""
# Prepare test data
test_data_csv = """id,truth_value,family_name,given_name,gender,birth_date,phone,street_address,city,state,postal_code,SSN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0301: Line too long (126/100) (line-too-long)

cli/deduplifhirLib/tests/main_test.py
"""
return CliRunner()

def test_dedupe_data_with_csv_output(cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
# Clean up: delete output file
os.remove(output_path)

def test_dedupe_data_with_specific_csv(cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
os.remove('specific.csv')


def test_dedupe_data_with_json_output(cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
# Clean up: delete output file
os.remove(output_path)

def test_dedupe_data_with_invalid_format(cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
os.remove(output_path)
os.remove(bad_data_path)

def test_dedupe_accuracy(cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
5000,
2500
],indirect=True)
def test_dedupe_data_with_large_dataset(generate_mock_data_fixture, cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'generate_mock_data_fixture' from outer scope (line 18) (redefined-outer-name)

cli/deduplifhirLib/tests/main_test.py
5000,
2500
],indirect=True)
def test_dedupe_data_with_large_dataset(generate_mock_data_fixture, cli_runner):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'cli_runner' from outer scope (line 36) (redefined-outer-name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firebird1029 @IsaacMilarky