Add frontend tests #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
Firebird1029
force-pushed
the
frontend-tests-2
branch
from
da7406c
to
81cc828
Compare
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
natalialuzuriaga
requested changes
Jul 9, 2024
patsier-cms
requested changes
Jul 9, 2024
Signed-off-by: Brandon Yee <6111102+Firebird1029@users.noreply.github.com>
patsier-cms
approved these changes
Jul 11, 2024
|
Yeah, I discussed it with Natalia, I originally added it to frontend-checks but couldn't figure it out since Electron requires a GUI to test but the Ubuntu Github Actions servers don't have GUIs by default. Should be possible but might need some time to figure out. |
|
@Firebird1029 let's definitely split this out, but you should be able to use a headless browser specifically for this, and playwright has built-in support. Happy to set up some time to talk through it a bit more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add frontend tests
Problem
Currently, the Electron app frontend lacks frontend tests.
Solution
This PR adds some frontend tests to ensure the Electron app works correctly.
Result
To run the tests:
To install the tests (once):
cd frontend npm install npx playwright install