Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Anticipate IDs usage #37

Merged
merged 7 commits into from
Mar 7, 2023
Merged

feat: Anticipate IDs usage #37

merged 7 commits into from
Mar 7, 2023

Conversation

ewuerger
Copy link
Member

This PR anticipates the latest changes to the snapshot interface, using just the identifiers of objects. The documentation was changed too and the corresponding warning section was removed. the JSONschema needed an update too.

@ewuerger
feat: Use identifier in data_types and requirement_types
664240e 
Before this change the procedure used `long_name`s to match any
`attribute_definition` found under a `requirement_type`. The snapshot
disallows this by using only identifiers.
@ewuerger
docs: Update documentation
72de6da
@ewuerger
refactor: Get rid of redundant ReqFinder and methods
da346b6
@ewuerger ewuerger added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 21, 2023
@ewuerger ewuerger self-assigned this Feb 21, 2023
@ewuerger ewuerger changed the title feat: Anticipate ids usage feat: Anticipate IDs usage Feb 21, 2023
@ewuerger ewuerger force-pushed the anticipate-ids-usage branch from 4735b18 to 6108f52 Compare February 21, 2023 15:12
@ewuerger ewuerger marked this pull request as draft February 22, 2023 13:48
@ewuerger ewuerger marked this pull request as ready for review February 23, 2023 12:52
Wuestengecko
Wuestengecko requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@Wuestengecko Wuestengecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After spending several hours working through this PR, I can conclude: I have no idea what's going on here. But the theory sounds good.

capella_rm_bridge/changeset/change.py Outdated Show resolved Hide resolved
capella_rm_bridge/changeset/find.py Outdated Show resolved Hide resolved
docs/source/snapshot.rst Show resolved Hide resolved
docs/source/snapshot.rst Outdated Show resolved Hide resolved
@ewuerger ewuerger mentioned this pull request Mar 3, 2023
Open
@ewuerger ewuerger force-pushed the anticipate-ids-usage branch from 6ff8e33 to fd84c08 Compare March 3, 2023 14:27
@ewuerger ewuerger force-pushed the anticipate-ids-usage branch from fd84c08 to 03612b6 Compare March 6, 2023 10:35
@ewuerger ewuerger force-pushed the anticipate-ids-usage branch from 03612b6 to 3cad88b Compare March 7, 2023 09:40
@ewuerger ewuerger merged commit bf663ec into master Mar 7, 2023
@ewuerger ewuerger deleted the anticipate-ids-usage branch March 7, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wuestengecko Wuestengecko Wuestengecko approved these changes

@jamilraichouni jamilraichouni Awaiting requested review from jamilraichouni

Assignees

@ewuerger ewuerger

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @Wuestengecko