Fix/early withdrawal manipulation #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…power needed for execution
…ble to Proposal struct and modified logic for end proposal execution
|
I'm not sure this is the solution we want here. What we are essentially making is a half snapshot approach where the amount to execute is snapshotted but individual's voting power is not. This could lead to some bad behaviour as quorum will not scale on an active proposal. |
|
Yes, I just saw that Madusha #187 fixes this. Closing the issue for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #167, and DXD-19 in the audit.
Users were allowed to decrease voting power for proposal execution by withdrawing their tokens after voting.
Added a new variable to
Proposalstruct: votingPowerForProposalExecution.Now, the voting power is calculated at the time of proposal creation and stored. Then, when executing the proposal, voting power is read from the Proposal instead of calculated on the fly.