Bugfix/double voting bug #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore voted proposal.
rossneilson
approved these changes
Jun 28, 2022
AugustoL
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150 - DXD-02: Double-voting in
BaseERC20Guild.Previous behavior:
After locking tokens and voting on a proposal, a user could withdraw their tokens when their locking period ends, even if the voting hasn't finished. This way, it was possible for the tokens to be moved to a different wallet and used for voting again.
New behavior:
Whenever a user votes on a proposal, their token lock-time is extended to at least the end time of the voted proposal, preventing the attack.
Modified
BaseERC20Guild.soland added tests.