[hak.lee] week 1 #305
Merged
[hak.lee] week 1 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleSeo
reviewed
Aug 11, 2024
Comment on lines
+3
to
+12
| ref: https://wiki.python.org/moin/TimeComplexity | ||
| set는 dict와 거의 비슷하게 구현되어 있는데, | ||
| dict의 `Set Item`의 Average Case는 O(1)이더라도 | ||
| Amortized Worst Case가 O(n)이다! | ||
|
|
||
| 즉, set에 아이템을 추가할때마다 해시 충돌이 일어날 경우 | ||
| 최악의 경우 O(n^2)이 걸리므로, 아래의 set(nums)의 | ||
| TC가 O(n^2)이 되는 것일까..? | ||
|
|
||
| set(nums)의 결과가 최악의 경우 SC가 O(n)이다. |
There was a problem hiding this comment.
일반적으로 코딩 테스트에서는 이 정도까지 깊은 복잡도 분석을 요하지는 않습니다. 대부분의 개발자들은 해시 충돌이 거의 일어나지 않는다는 것을 가정하고 해시 테이블 기반의 자료 구조를 사용합니다. 따라서 이 풀이의 시간 복잡도는 O(n)라고 하시더라도 면접관과 크게 논쟁의 여지는 없을 것 같습니다.
leokim0922
reviewed
Aug 11, 2024
top-k-frequent-elements/haklee.py
Outdated
| class Solution: | ||
| def topKFrequent(self, nums: List[int], n: int) -> List[int]: | ||
| d = {} | ||
| [d.update({i: d.get(i, 0) + 1}) for i in nums] |
There was a problem hiding this comment.
해당 코드도 충분히 좋아보입니다만, collections 모듈을 써서 가독성을 높이는거도 좋아보입니다 😄
There was a problem hiding this comment.
Counter를 써서 한 줄 솔루션으로 바꿔보았습니다!
|
안녕하세요, 코치 Helena 입니다. |
nhistory
approved these changes
Aug 16, 2024
SamTheKorean
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.