Include second CPU in DT #101
Conversation
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/dt_with_2nd_cpu
branch
2 times, most recently
from
c3bde9f to
d5268a4
Compare
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/tod_2nd_cpu
branch
from
bb66b33 to
14f65d9
Compare
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/dt_with_2nd_cpu
branch
from
d5268a4 to
6cab1de
Compare
There was a problem hiding this comment.
Some of this is changed in #106. It seems there is much more that have to be generated by code than initially expected.
| sensor@13 { | ||
| compatible = "ibm,ipmi-sensor"; | ||
| ipmi-sensor-type = <0x0c>; | ||
| reg = <0x13>; | ||
| }; | ||
|
|
||
| sensor@15 { | ||
| compatible = "ibm,ipmi-sensor"; | ||
| ipmi-sensor-type = <0x0c>; | ||
| reg = <0x15>; | ||
| }; | ||
|
|
||
| sensor@19 { | ||
| compatible = "ibm,ipmi-sensor"; | ||
| ipmi-sensor-type = <0x0c>; | ||
| reg = <0x19>; | ||
| }; |
There was a problem hiding this comment.
These are all memory sensors, seems there is one per installed DIMM and there is one reg reserved per unpopulated slot. These also have to be generated by code, depending on actual setup. It may require passing data from romstage, maybe worth exposing whole SPD (related issue), since Hostboot does it?
There was a problem hiding this comment.
Not sure if SPD plays a role in this. At the moment I suspect that sensors are selected based on HUID (I think I saw it in the code) while all possible values are simply hard-coded in talos.xml. But HUID might depend on SPD data.
There was a problem hiding this comment.
SPD data isn't necessary, it's about position of DIMM, but I made whole mem_data available in ramstage, so now it's possible to generate memory and SPD nodes there.
Assumption is that it can still work for one CPU. Change-Id: Ic8612b747a8036c6bb6711dc05d36515ea190346 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: Ib1c8831c792ccce61925408ea19fddca682b476e Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: I51915169640631ab9406202ea3112044aec07dd7 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Put validation into a separate function. Change-Id: Ie04da44b1beb6010afe8cda527340e5d234cc4e1 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/dt_with_2nd_cpu
branch
from
6cab1de to
d6010ce
Compare
Change-Id: I58f9204eee786f9bda1e14ffa2992a75f4b773a5 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
It's needed as a source of information for building device tree. Change-Id: I306d384186c4677452d531d490cde495b1129204 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Two nodes per installed DIMM: state (presence) and temperature sensors. Change-Id: I297c4820679491699fcdfea173d6fbd01eddbe75 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/dt_with_2nd_cpu
branch
from
34068fb to
487d707
Compare
No description provided.