mb/lenovo/m900_tiny: add board #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It boots to UEFIPayload but throws error MrChromebox and Dasharo EDK2 both show this issue, with or without secureboot enabled. |
|
It was a TPM issue. Now it boots, straight to Windows 10 without issues :) |
Merged
|
Basically everything works apart from S3 suspend. Had to disable PCI ASPM L1 substate to get the Wi-Fi slot to work. |
|
S3 fix: Dasharo/edk2#89 |
|
Added LPSS UART support, as I don't have the COM port module anymore. TX/RX are pins 16-17 on GXDP connector on the underside of the board. Also added VR configuration and implemented SMMSTORE wipe by CMOS clear header. Currently fighting to enable TXT, so far SINIT ACM reports error class 0xD, code 1.a or 1.0, and the ACM call test results in a reset. Maybe rebasing on fresh dasharo branch will help here. The schematics refer to a Google SKU, which would have additional I/O using the proprietary PCIe + SATA header, some extra USB features and firmware write-protect controlled by GPIO, but I couldn't find any reference to such a device in coreboot or chromium git histories, so I guess it was cancelled pretty early on. |
|
Log from just before the reset: |
|
So Kaby Lake FSP is built without TXT support, so TXT init in coreboot fails, because FSP is expected to execute BIOS ACM Acheck function. Amberlake does not work presumably for the same reason, since the same FSP params are missing. I tried hacking up a custom FSP (skipping some TPM checks that failed due to missing PPIs) and got as far as Acheck preparation, but the ACM launch function is not compiled when using GCC. Might try porting some changes from later FSPs to see if I can get it to work. @macpijan might be relevant to you too |
Yup, the TXT switch in KBL FSP source is default FALSE :( |
|
Added the revision that was merged upstream and enabled CI builds. Any further features will be developed in subsequent PRs. |
Change-Id: I58acc105c0e04c02cffce84e0306d07a28c52441 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Change-Id: Ice74ea3a1ceae446d79b64e051debd0c0555ea2c Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
|
I've compiled coreboot FW for M700 Tiny. Wifi slot (m.2 sff) does not work at all, device (Intel AC wifi card 8260 w bluetooth) is not enumerated at all - Bluetooth part works (I know, it's USB). ASPM disabled or enabled - NO difference. This machine does not have pcie on the M2/NVME slot, just sata (thanks lenovo/intel). On original OEM firmware everything works. I leave here the boot log from cbmem, I can make other tests/experiments if you want: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boots to UEFIPayload. TODO: