-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2158][risk=no] Swap default pages for researcher tab #1877
Conversation
{ label: 'DAR Requests', link: '/researcher_console' }, | ||
{ label: 'Data Catalog', link: '/dataset_catalog' } | ||
{ label: 'Data Catalog', link: '/dataset_catalog' }, | ||
{ label: 'DAR Requests', link: '/researcher_console' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is /researcher_console
an inaccurate url now that it isn't the default? I could see this being a big change though, considering we likely have links pointing to this page in many places, so maybe not worth changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is /researcher_console an inaccurate url now that it isn't the default?
Changing that is outside the scope of what I'm trying to do here. The only goal is to arrange the default tabs for the researcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the thoughts above (which don't really have any action items for this ticket), this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks pretty straightforward herebut I'm noticing the same behavior that Connor pointed out.
Clicking on the Researcher Console tab in the header navigates me to https://local.broadinstitute.org:3000/dataset_catalog but the Header shows one of the other consoles being selected. If already in the DAC Chair Console or DAC Member Console, clicking on the "Researcher Console" switches to one of the "Datasets" tab within the Chair or Member consoles. Otherwise it navigates to the Admin Console / Dataset Catalog and I can not access the Researcher Console / DAR Requests tab. Not sure how to address this.
There is some weirdness with the selected tab state - I'll dig into that. |
@quazi-broad @connorlbark - Connor fixed the bug, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Researcher Console tabs are working correctly with the new changes. Everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 updating approval
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2158
The default page for the researcher console is now set to the dataset catalog instead of the user's DARs.
Old
New
Have you read Terra's Contributing Guide lately? If not, do that first.