Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2158][risk=no] Swap default pages for researcher tab #1877

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[DUOS-2158][risk=no] Swap default pages for researcher tab #1877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5512a71
swap default pages for researcher tab
rushtong Nov 3, 2022
25d6bc5
fix navigation header not working
connorlbark Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/DuosHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ export const headerTabsConfig = [
},
{
label: 'Researcher Console',
link: '/researcher_console',
search: 'researcher_console',
link: '/dataset_catalog',
search: 'dataset_catalog',
children: [
{ label: 'DAR Requests', link: '/researcher_console' },
{ label: 'Data Catalog', link: '/dataset_catalog' }
{ label: 'Data Catalog', link: '/dataset_catalog' },
{ label: 'DAR Requests', link: '/researcher_console' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is /researcher_console an inaccurate url now that it isn't the default? I could see this being a big change though, considering we likely have links pointing to this page in many places, so maybe not worth changing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is /researcher_console an inaccurate url now that it isn't the default?

Changing that is outside the scope of what I'm trying to do here. The only goal is to arrange the default tabs for the researcher.

],
isRendered: (user) => user.isResearcher
}
Expand Down Expand Up @@ -181,7 +181,7 @@ const NavigationTabsComponent = (props) => {
to: {
pathname: tab.link,
state: {
selectedMenuTab: selectedMenuTab,
selectedMenuTab: tabIndex,
},
},
component: Link
Expand Down