[DCJ-627][risk=low] Remove deprecated Dataset needsApproval and active state attributes. #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated URL in readme to replace comma with a period
otchet-broad
changed the title
otchet-broad
requested review from
rushtong and
fboulnois
and removed request for
a team
|
Thanks for the thumbs! |
otchet-broad
deleted the
otchet/DCJ-627-remove-deprecated-dataset-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Addresses the UI portion of removing deprecated Dataset properties
Summary
Removing needsApproval and active Dataset interface properties that are marked deprecated in consent. Drive by fix of punctuation in the DEVNOTES.md that was discovered while tooling my local dev environment.
These properties were already (largely) ignored by the frontend code.
See also
DataBiosphere/consent#2399