Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-627][risk=low] Remove deprecated Dataset needsApproval and active state attributes. #2663

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[DCJ-627][risk=low] Remove deprecated Dataset needsApproval and active state attributes. #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVNOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ run in GitHub Actions. Create a `cypress.env.json` file in the root of your
local repo that looks like this:
```json
{
"baseUrl": "https://local.dsde-dev,broadinstitute.org:3000/"
"baseUrl": "https://local.dsde-dev.broadinstitute.org:3000/"
}
```
Cypress will use these values in `cypress.config.js` and `cypress/support/commands.js`
Expand Down
4 changes: 0 additions & 4 deletions cypress/component/DarCollectionReview/dar_collection_review.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,7 @@ const dar = {
'createUserId': null,
'updateDate': 1643730658770,
'updateUserId': 11111,
'active': true,
'consentName': null,
'needsApproval': null,
'alias': 999,
'datasetIdentifier': 'DUOS-00999',
'dataUse': {
Expand Down Expand Up @@ -670,8 +668,6 @@ const dacDatasets = [{
'propertyValue': 'Sleep Apnea'
}
],
'active': true,
'needsApproval': true,
'isAssociatedToDataOwners': null,
'updateAssociationToDataOwnerAllowed': null,
'alias': 999,
Expand Down
2 changes: 0 additions & 2 deletions src/types/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ export interface Dataset {
deletable: boolean;
properties: DatasetProperty[];
study: Study;
active: boolean;
needsApproval: boolean;
alias: string;
datasetIdentifier: string;
objectId: string;
Expand Down
Loading