Skip to content

Commit

Permalink
🏷️ adjust types to allow updating the SDK in Datadog app (#1587)
Browse files Browse the repository at this point in the history
* make `startView` argument optional

* export TimeStamp from `/internal`

Since 85e732d , Records timestamp is
using the TimeStamp type. We need it to mock records in web-ui
  • Loading branch information
BenoitZugmeyer authored Jun 9, 2022
1 parent 8a04447 commit 336ebe7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/rum-core/src/boot/rumPublicApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export function makeRumPublicApi(
}

const startView: {
(name: string): void
(name?: string): void
// (options: ViewOptions): void // uncomment when removing the feature flag
} = monitor((options?: string) => {
const sanitizedOptions = typeof options === 'object' ? options : { name: options }
Expand Down
1 change: 1 addition & 0 deletions packages/rum/src/entries/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* WARNING: this module is not intended for public usages, and won't follow semver for breaking
* changes.
*/
export type { TimeStamp } from '@datadog/browser-core'
export { PRIVACY_ATTR_NAME, PRIVACY_ATTR_VALUE_HIDDEN, PRIVACY_CLASS_HIDDEN, NodePrivacyLevel } from '../constants'

export * from '../types'
Expand Down

0 comments on commit 336ebe7

Please sign in to comment.