Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏷️ adjust types to allow updating the SDK in Datadog app #1587

Merged
merged 2 commits into from
Jun 9, 2022
Merged

🏷️ adjust types to allow updating the SDK in Datadog app #1587

merged 2 commits into from
Jun 9, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jun 9, 2022 •
edited by bcaudan
Loading

Motivation

  • the Datadog app is using startView(undefined), but the types don't allow that anymore
  • the Datadog app is mocking Records, which now have TimeStamp values

Changes

  • Adjust startView typing
  • Export TimeStamp from /internal

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer
make startView argument optional
8a67337
@BenoitZugmeyer
export TimeStamp from /internal
aec304d 
Since 85e732d , Records timestamp is
using the TimeStamp type. We need it to mock records in web-ui
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review June 9, 2022 15:14
@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners June 9, 2022 15:14
@BenoitZugmeyer BenoitZugmeyer merged commit 336ebe7 into main Jun 9, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/adjust-types branch June 9, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amortemousque amortemousque amortemousque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenoitZugmeyer @amortemousque