Skip to content

Commit

Permalink
πŸ“πŸ—‘ deprecate the XHR context, to be removed in V4 (#973)
Browse files Browse the repository at this point in the history
  • Loading branch information
BenoitZugmeyer authored Aug 4, 2021
1 parent 310fc2e commit d3229fe
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions packages/core/src/browser/xhrProxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ import { Duration, elapsed, relativeNow, RelativeTime, ClocksState, clocksNow, t
import { normalizeUrl } from '../tools/urlPolyfill'

interface BrowserXHR<T extends XhrOpenContext> extends XMLHttpRequest {
/**
* @deprecated this property is shared by both logs and rum and can be used by different code
* versions depending on customer setup. To improve reliability and make SDKs independent, this
* property should be removed in the future, but this would be a breaking change since some
* customers are using it.
*
* TODO(v4): replace this property with a weakmap index
*/
_datadog_xhr?: T
}

Expand Down

0 comments on commit d3229fe

Please sign in to comment.