Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝🗑 deprecate the XHR context, to be removed in V4 #973

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

xhr._datadog_xhr is problematic because it is shared between SDKs

Changes

Deprecate xhr._datadog_xhr. No replacement for now, but we might want to remove it in a future major version.

Testing


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 3, 2021 15:31
@BenoitZugmeyer BenoitZugmeyer merged commit d3229fe into main Aug 4, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/deprecate-xhr-context branch August 4, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants