Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝🗑 deprecate the XHR context, to be removed in V4 #973

Merged
merged 2 commits into from
Aug 4, 2021
Merged

📝🗑 deprecate the XHR context, to be removed in V4 #973

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1b9f08
📝🗑 deprecate the XHR context, to be removed in V4
BenoitZugmeyer Aug 3, 2021
2d78a9a
Merge branch 'main' into benoit/deprecate-xhr-context
BenoitZugmeyer Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/browser/xhrProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ import { Duration, elapsed, relativeNow, RelativeTime, ClocksState, clocksNow, t
import { normalizeUrl } from '../tools/urlPolyfill'

interface BrowserXHR<T extends XhrOpenContext> extends XMLHttpRequest {
/**
* @deprecated this property is shared by both logs and rum and can be used by different code
* versions depending on customer setup. To improve reliability and make SDKs independent, this
* property should be removed in the future, but this would be a breaking change since some
* customers are using it.
*
* TODO(v4): replace this property with a weakmap index
*/
_datadog_xhr?: T
}

Expand Down