-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗[RUMF-1079] add lock mechanism for session cookie writes #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/session-lock
branch
2 times, most recently
from
December 21, 2021 16:13
41ef380
to
c38fe8c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
+ Coverage 89.13% 89.29% +0.15%
==========================================
Files 104 105 +1
Lines 4254 4317 +63
Branches 962 979 +17
==========================================
+ Hits 3792 3855 +63
Misses 462 462
Continue to review full report at Codecov.
|
bcaudan
force-pushed
the
bcaudan/session-lock
branch
from
December 22, 2021 14:28
87ab8dc
to
8a5c553
Compare
bcaudan
force-pushed
the
bcaudan/session-lock
branch
from
December 22, 2021 14:31
8a5c553
to
c484ce3
Compare
bcaudan
force-pushed
the
bcaudan/session-lock
branch
from
January 5, 2022 11:32
1d5db83
to
7b786fe
Compare
BenoitZugmeyer
approved these changes
Jan 5, 2022
amortemousque
approved these changes
Jan 5, 2022
Bump to the next version with still some usage https://caniuse.com/usage-table
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mitigate session inconsistencies due to concurrent access to cookies by different tabs (chromium browsers).
Changes
cookie-lock
Testing
I have gone over the contributing documentation.