Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1079] limit session inconsistencies issue on chromium browsers #1327

Merged
merged 6 commits into from
Feb 14, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 8, 2022

Motivation

Mitigate session inconsistencies due to concurrent access to cookies by different tabs on chromium browsers.

Changes

Enable changes introduced by:

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner February 8, 2022 15:22
it seems that the cookie can still be present with an empty value after the deleteAllCookies
mostly on android but also seen on edge
@codecov-commenter
Copy link

Codecov Report

Merging #1327 (33bf4dc) into main (fb5c2bf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         105      105           
  Lines        4387     4387           
  Branches      992      991    -1     
=======================================
  Hits         3948     3948           
  Misses        439      439           
Impacted Files Coverage Δ
...ages/core/src/domain/session/sessionCookieStore.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5c2bf...33bf4dc. Read the comment docs.

@bcaudan bcaudan merged commit b4a58e6 into main Feb 14, 2022
@bcaudan bcaudan deleted the bcaudan/enable-cookie-lock branch February 14, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants