Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1277] rename frustration types #1557

Merged
merged 2 commits into from
May 23, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented May 23, 2022

Motivation

See related PR: DataDog/rum-events-format#60

Changes

Rename frustration type values

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 23, 2022 13:09
@codecov-commenter
Copy link

Codecov Report

Merging #1557 (b375c8f) into main (de418d9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1557   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files         117      117           
  Lines        4496     4496           
  Branches     1014     1014           
=======================================
  Hits         4069     4069           
  Misses        427      427           
Impacted Files Coverage Δ
...omain/rumEventsCollection/action/rageClickChain.ts 100.00% <100.00%> (ø)
...in/rumEventsCollection/action/trackClickActions.ts 97.87% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--rename-types branch from b375c8f to 5a4d9a8 Compare May 23, 2022 13:14
@BenoitZugmeyer BenoitZugmeyer merged commit 1a43bfc into main May 23, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/frustration-signals--rename-types branch May 23, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants