[RUMF-1277] rename frustration types #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/rename-frustration-types
branch
from
3102230 to
eafe4b8
Compare
louisj-dd
approved these changes
May 20, 2022
bcaudan
approved these changes
May 20, 2022
xgouchet
approved these changes
May 23, 2022
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dogfooding, we found out that we are showing the frustration type alone in many places (ex: facet, chart legend,…). Showing “dead” or “rage” alone is not really meaningful and can be a bit shocking or hurtful (we don’t want to display “dead” all over the place).
In the last sync, we chose to rename
deadtodead_clickand so forth. It will change a bit how we make analytics when we have frustration associated to mutliple types of action (ex:rage_clickis similar torage_tap, but both will need to be specified when querying any rage inducing frustration). This is a small drawback but we decided that we can live with it.