Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-1263] ⚡ Ignore link tags with rel=modulepreload|prefetch #1921

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

yannickadam
Copy link
Contributor

@yannickadam yannickadam commented Jan 5, 2023

Motivation

Ignore elements of type:

<link rel="preload" as="script">
<link rel="modulepreload" as="script">
<link rel="prefetch" as="script">

to decrease payload, as they are ignored as well by replay.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@yannickadam yannickadam requested review from a team as code owners January 5, 2023 16:53
@yannickadam yannickadam changed the title ⚡ Ignore modulepreload in link tags [RUMF-1263] ⚡ Ignore rel=modulepreload in link tags Jan 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1921 (a3774ef) into main (ac26b8d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   93.21%   93.28%   +0.07%     
==========================================
  Files         141      141              
  Lines        5349     5349              
  Branches     1202     1202              
==========================================
+ Hits         4986     4990       +4     
+ Misses        363      359       -4     
Impacted Files Coverage Δ
packages/rum/src/domain/record/privacy.ts 97.84% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 96.92% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yannickadam yannickadam changed the title [RUMF-1263] ⚡ Ignore rel=modulepreload in link tags [RUMF-1263] ⚡ Ignore link tags with rel=modulepreload Jan 5, 2023
@yannickadam yannickadam force-pushed the yannick.adam/RUMF-1263-module_preload branch from a3774ef to 30633b6 Compare January 9, 2023 15:29
@yannickadam yannickadam changed the title [RUMF-1263] ⚡ Ignore link tags with rel=modulepreload [RUMF-1263] ⚡ Ignore link tags with rel=modulepreload|prefetch Jan 9, 2023
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yannickadam yannickadam merged commit 8f2d1aa into main Jan 11, 2023
@yannickadam yannickadam deleted the yannick.adam/RUMF-1263-module_preload branch January 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants