-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️[RUMF-1517] split core specHelper #2111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
2 times, most recently
from
March 27, 2023 14:30
e027a63
to
7406f9c
Compare
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
2 times, most recently
from
March 28, 2023 13:14
6352771
to
193e82d
Compare
4 tasks
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
from
March 28, 2023 13:25
193e82d
to
596f4c0
Compare
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 93.73% 93.65% -0.08%
==========================================
Files 164 174 +10
Lines 5694 5961 +267
Branches 1303 1338 +35
==========================================
+ Hits 5337 5583 +246
- Misses 357 378 +21
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
3 times, most recently
from
March 29, 2023 08:00
25550c8
to
97cd93e
Compare
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
from
March 29, 2023 08:06
97cd93e
to
bf56518
Compare
bcaudan
force-pushed
the
bcaudan/split-core-specHelper
branch
from
March 29, 2023 08:51
048436f
to
0de378e
Compare
BenoitZugmeyer
approved these changes
Mar 29, 2023
amortemousque
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid single utils files
Changes
clearAllCookies
toforEach.spec
capturedExceptions
totracekit
core/test/specHelper
:browserChecks
buildEnv
createNewEvent
mockClock
requests.specHelper
location.specHelper
specHelper
tosimpleTestDoubles
Testing
I have gone over the contributing documentation.