Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-1517] split core specHelper #2111

Merged
merged 12 commits into from
Mar 29, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 27, 2023

Motivation

Avoid single utils files

Changes

  • move clearAllCookies to forEach.spec
  • move capturedExceptions to tracekit
  • extract from core/test/specHelper:
    • browserChecks
    • buildEnv
    • createNewEvent
    • mockClock
    • requests.specHelper
    • location.specHelper
  • rename specHelper to simpleTestDoubles

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link
Contributor Author

bcaudan commented Mar 27, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch 2 times, most recently from e027a63 to 7406f9c Compare March 27, 2023 14:30
Base automatically changed from bcaudan/split-spec-helper to main March 28, 2023 07:36
@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch 2 times, most recently from 6352771 to 193e82d Compare March 28, 2023 13:14
@bcaudan bcaudan changed the base branch from main to bcaudan/add-index March 28, 2023 13:18
@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch from 193e82d to 596f4c0 Compare March 28, 2023 13:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #2111 (048436f) into main (0b18707) will decrease coverage by 0.08%.
The diff coverage is 95.72%.

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
- Coverage   93.73%   93.65%   -0.08%     
==========================================
  Files         164      174      +10     
  Lines        5694     5961     +267     
  Branches     1303     1338      +35     
==========================================
+ Hits         5337     5583     +246     
- Misses        357      378      +21     
Impacted Files Coverage Δ
packages/core/test/emulate/stubReportApis.ts 93.75% <ø> (ø)
packages/core/test/emulate/stubZoneJs.ts 100.00% <ø> (ø)
...ckages/core/test/emulate/syntheticsWorkerValues.ts 100.00% <ø> (ø)
packages/core/test/emulate/createNewEvent.ts 80.00% <80.00%> (ø)
packages/core/test/emulate/eventBridge.ts 87.50% <87.50%> (ø)
packages/core/test/requests.ts 93.71% <95.12%> (ø)
packages/core/test/browserChecks.ts 100.00% <100.00%> (ø)
packages/core/test/emulate/cookie.ts 100.00% <100.00%> (ø)
packages/core/test/emulate/location.ts 100.00% <100.00%> (ø)
packages/core/test/emulate/mockClock.ts 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan marked this pull request as ready for review March 28, 2023 13:43
@bcaudan bcaudan requested a review from a team as a code owner March 28, 2023 13:43
@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch 3 times, most recently from 25550c8 to 97cd93e Compare March 29, 2023 08:00
Base automatically changed from bcaudan/add-index to main March 29, 2023 08:05
@bcaudan bcaudan requested a review from a team as a code owner March 29, 2023 08:05
@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch from 97cd93e to bf56518 Compare March 29, 2023 08:06
@bcaudan bcaudan force-pushed the bcaudan/split-core-specHelper branch from 048436f to 0de378e Compare March 29, 2023 08:51
@bcaudan bcaudan merged commit 5578fe2 into main Mar 29, 2023
@bcaudan bcaudan deleted the bcaudan/split-core-specHelper branch March 29, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants