Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-1517] split rum test utils #2117

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 28, 2023

Motivation

Avoid single utils files

Changes

  • From rum/test/utils:
    • extract mockWorker
    • extract mutationPayloadValidator
    • extract segments.specHelper
    • extract nodes.specHelper
    • extract observers.specHelper
    • move parseSegment to segment.spec.ts
  • rename utils in recordsPerFullSnapshot

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link
Contributor Author

bcaudan commented Mar 28, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #2117 (882ec36) into main (0b18707) will decrease coverage by 0.06%.
The diff coverage is 83.13%.

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
- Coverage   93.73%   93.67%   -0.06%     
==========================================
  Files         164      168       +4     
  Lines        5694     5690       -4     
  Branches     1303     1303              
==========================================
- Hits         5337     5330       -7     
- Misses        357      360       +3     
Impacted Files Coverage Δ
packages/rum/test/segments.ts 11.76% <11.76%> (ø)
packages/rum/test/mutationPayloadValidator.ts 82.75% <82.75%> (ø)
packages/rum/test/nodes.ts 87.50% <87.50%> (ø)
packages/rum/test/mockWorker.ts 100.00% <100.00%> (ø)
packages/rum/test/recordsPerFullSnapshot.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan force-pushed the bcaudan/split-rum-test-utils branch 3 times, most recently from 15f2275 to a3a3eb9 Compare March 29, 2023 08:00
Base automatically changed from bcaudan/add-index to main March 29, 2023 08:05
@bcaudan bcaudan force-pushed the bcaudan/split-rum-test-utils branch from a3a3eb9 to 6d21ab2 Compare March 29, 2023 08:06
@bcaudan bcaudan force-pushed the bcaudan/split-rum-test-utils branch from 6d21ab2 to 882ec36 Compare March 29, 2023 08:15
@bcaudan bcaudan marked this pull request as ready for review March 29, 2023 08:22
@bcaudan bcaudan requested review from a team as code owners March 29, 2023 08:22
@bcaudan bcaudan merged commit 84e1ff5 into main Mar 29, 2023
@bcaudan bcaudan deleted the bcaudan/split-rum-test-utils branch March 29, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants