-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️[RUMF-1517] split rum test utils #2117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
- Coverage 93.73% 93.67% -0.06%
==========================================
Files 164 168 +4
Lines 5694 5690 -4
Branches 1303 1303
==========================================
- Hits 5337 5330 -7
- Misses 357 360 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
force-pushed
the
bcaudan/split-rum-test-utils
branch
3 times, most recently
from
March 29, 2023 08:00
15f2275
to
a3a3eb9
Compare
bcaudan
force-pushed
the
bcaudan/split-rum-test-utils
branch
from
March 29, 2023 08:06
a3a3eb9
to
6d21ab2
Compare
bcaudan
force-pushed
the
bcaudan/split-rum-test-utils
branch
from
March 29, 2023 08:15
6d21ab2
to
882ec36
Compare
BenoitZugmeyer
approved these changes
Mar 29, 2023
amortemousque
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid single utils files
Changes
rum/test/utils
:mockWorker
mutationPayloadValidator
segments.specHelper
nodes.specHelper
observers.specHelper
utils
inrecordsPerFullSnapshot
Testing
I have gone over the contributing documentation.