Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊[RUM-2324] Telemetry on LCP with startTime to 0 #2515

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Nov 29, 2023

Motivation

Collect telemetry on LCP with startTime to 0:

{
  entry // the entry reported by the performanceObserver API
  previousNonZeroLcp,
  navigationStart // check if there is an unexpected navigationStart
  timeOrigin // check if there is an unexpected timeOrigin
  now: performance.now() // check the diff between now and the entry timings,
  visibilityState // check if these reports happens when "hidden" | "visible" | "prerender",
  prerendering: document.prerendering,
}

Changes

Add telemetry on LCP with a startTime at 0

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 29, 2023 14:47
@amortemousque amortemousque changed the title [RUM-2324] Telemetry on LCP with startTime to 0 🔊[RUM-2324] Telemetry on LCP with startTime to 0 Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (603d6a0) 93.22% compared to head (decf74a) 93.14%.
Report is 16 commits behind head on main.

Files Patch % Lines
...in/view/viewMetrics/trackLargestContentfulPaint.ts 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2515      +/-   ##
==========================================
- Coverage   93.22%   93.14%   -0.08%     
==========================================
  Files         222      222              
  Lines        6654     6665      +11     
  Branches     1460     1463       +3     
==========================================
+ Hits         6203     6208       +5     
- Misses        451      457       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcaudan
Copy link
Contributor

bcaudan commented Dec 14, 2023

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 14, 2023

🚂 Branch Integration: starting soon, merge in < 3s

Commit decf74ae14 will soon be integrated into staging-50.

This build is going to start soon! (estimated merge in less than 3s)

you can cancel this operation by commenting your pull request with /to-staging -c!

@bcaudan bcaudan merged commit 33b7220 into main Dec 14, 2023
15 of 17 checks passed
@bcaudan bcaudan deleted the aymeric/zero-lcp-telemetry branch December 14, 2023 16:47
@bcaudan
Copy link
Contributor

bcaudan commented Dec 14, 2023

/to-staging -c

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 14, 2023

🚂 Devflow: to-staging -c

Integration of decf74ae14 into staging-50 was cancelled!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 14, 2023

🚂 Branch Integration: This merge request build was cancelled

This merge request build was cancelled after being merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants