Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊[RUM-2324] Telemetry on other wrong LCP cases #2531

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 15, 2023

Motivation

Following #2515, some LCP data seemed wrong for other reasons than startTime = 0.

Changes

  • collect debug logs for LCP with startTime < previous LCP
  • collect debug logs for LCP with size < previous LCP
  • remove some debug data:
    • visibilityState: always visible
    • prerendering: always false
    • navigationStart: from one case, the value did not really make sense (~30s after timeOrigin) but not sure how reliable it is supposed to be anyway.
  • add lcpEntries to the debug data, to double check if the implementation difference with google may have an impact

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner December 15, 2023 16:58
@bcaudan
Copy link
Contributor Author

bcaudan commented Dec 15, 2023

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 15, 2023

🚂 Branch Integration: starting soon, merge in < 3s

Commit c1c27add40 will soon be integrated into staging-50.

This build is going to start soon! (estimated merge in less than 3s)

you can cancel this operation by commenting your pull request with /to-staging -c!

dd-mergequeue bot added a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 15, 2023

🚂 Branch Integration: This commit was successfully integrated

Commit c1c27add40 has been merged into staging-50 in merge commit cdc81f9e5d.

Check out the triggered pipeline on Gitlab 🦊

@amortemousque
Copy link
Contributor

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 18, 2023

🚂 Branch Integration: starting soon, merge in < 0s

Commit c1c27add40 will soon be integrated into staging-51.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

dd-mergequeue bot added a commit that referenced this pull request Dec 18, 2023
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 18, 2023

🚂 Branch Integration: This commit was successfully integrated

Commit c1c27add40 has been merged into staging-51 in merge commit 1ccefed72d.

Check out the triggered pipeline on Gitlab 🦊

@amortemousque amortemousque merged commit d7f2131 into main Dec 18, 2023
19 checks passed
@amortemousque amortemousque deleted the bcaudan/lcp-tweaks branch December 18, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants