-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-4629] accept null
as env/version/service
#2781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
=======================================
Coverage 93.58% 93.59%
=======================================
Files 242 242
Lines 7035 7037 +2
Branches 1548 1550 +2
=======================================
+ Hits 6584 6586 +2
Misses 451 451 ☔ View full report in Codecov by Sentry. |
/to-staging |
🚂 Branch Integration: this build is next, merge in < 9m Commit 7c91ae3f58 will soon be integrated into staging-21. This build is next! (estimated merge in less than 9m) Use |
Integrated commit sha: 7c91ae3 Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit 7c91ae3f58 has been merged into staging-21 in merge commit 61fcd80928. Check out the triggered pipeline on Gitlab 🦊 |
Hello @BenoitZugmeyer 👋 (😉 ) , Introducing the Is it intended ? |
👋 Hi @gscandola, it's not intended! |
Thanks a lot 👍 |
Motivation
Some customer pass
null
as version. Now that we validate that parameter, the initialization fails.See DataDog/dd-sdk-flutter#616
Regression caused by #2744
Changes
Do not reject
null
for tags.Testing
I have gone over the contributing documentation.