-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same service/version type in init()
and startView()
#2798
Use the same service/version type in init()
and startView()
#2798
Conversation
78dfe91
to
15d6ede
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 243 243
Lines 7112 7112
Branches 1583 1585 +2
=======================================
Hits 6659 6659
Misses 453 453 ☔ View full report in Codecov by Sentry. |
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 0s Commit 15d6eded0e will soon be integrated into staging-24. Use |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
…ing-24 Integrated commit sha: 15d6ede Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit 15d6eded0e has been merged into staging-24 in merge commit 53e71e2f4a. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
There is no reason why we shouldn't accept different types there. See #2781 (comment)
Changes
Change types, convert falsy values to undefined
Testing
I have gone over the contributing documentation.