Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same service/version type in init() and startView() #2798

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jun 7, 2024

Motivation

There is no reason why we shouldn't accept different types there. See #2781 (comment)

Changes

Change types, convert falsy values to undefined

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner June 7, 2024 14:38
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/use-same-types-for-service-version branch from 78dfe91 to 15d6ede Compare June 10, 2024 08:16
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (81981c0) to head (15d6ede).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2798   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         243      243           
  Lines        7112     7112           
  Branches     1583     1585    +2     
=======================================
  Hits         6659     6659           
  Misses        453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 10, 2024

🚂 Branch Integration: starting soon, median merge time is 0s

Commit 15d6eded0e will soon be integrated into staging-24.

Use /to-staging -c to cancel this operation!

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 158.74 KiB 158.75 KiB 16 B +0.01%
Logs 57.67 KiB 57.67 KiB 0 B 0.00%
Rum Slim 105.21 KiB 105.22 KiB 16 B +0.01%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.000
addaction 0.038 0.035 -0.003
adderror 0.035 0.034 -0.001
addtiming 0.001 0.001 -0.000
startview 1.270 0.808 -0.461
startstopsessionreplayrecording 0.942 0.743 -0.199
logmessage 0.006 0.005 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 19.68 KiB 20.39 KiB 723 B
addaction 69.82 KiB 68.41 KiB -1435 B
adderror 86.51 KiB 84.44 KiB -2124 B
addtiming 17.55 KiB 17.12 KiB -448 B
startview 312.30 KiB 317.70 KiB 5.40 KiB
startstopsessionreplayrecording 12.19 KiB 12.57 KiB 387 B
logmessage 67.54 KiB 69.34 KiB 1.80 KiB

dd-mergequeue bot added a commit that referenced this pull request Jun 10, 2024
…ing-24

Integrated commit sha: 15d6ede

Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 10, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 15d6eded0e has been merged into staging-24 in merge commit 53e71e2f4a.

Check out the triggered pipeline on Gitlab 🦊

@BenoitZugmeyer BenoitZugmeyer merged commit 9b21a36 into main Jun 13, 2024
21 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/use-same-types-for-service-version branch June 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants