-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-6956] Add action name source #3115
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
+ Coverage 93.63% 93.66% +0.02%
==========================================
Files 276 276
Lines 7620 7638 +18
Branches 1711 1716 +5
==========================================
+ Hits 7135 7154 +19
+ Misses 485 484 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 10m Commit d99b471eff will soon be integrated into staging-45. Use |
…g-45 Integrated commit sha: d99b471 Co-authored-by: cy-moi <congyao119@gmail.com>
Commit d99b471eff has been merged into staging-45 in merge commit abd1756a7f. Check out the triggered pipeline on Gitlab 🦊 |
|
/to-staging |
Devflow running:
|
…g-46 Integrated commit sha: d99b471 Co-authored-by: cy-moi <congyao119@gmail.com>
d99b471
to
83c70f9
Compare
83c70f9
to
ce77be2
Compare
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
const { name, nameSource } = | ||
typeof actionName === 'string' | ||
? { name: actionName, nameSource: ActionNameSource.STANDARD_ATTRIBUTE } | ||
: actionName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: I think it would be simpler if strategies didn't return string
. If you want to factorize attributes, you could have a function like:
function getActionNameFromStandardAttribute(element, attribute) {
return {
name: element.getAttribute(attribute),
nameSource: ActionNameSource.STANDARD_ATTRIBUTE
}
}
5341de5
to
673abd4
Compare
/to-staging |
Devflow running:
|
…g-47 Integrated commit sha: 673abd4 Co-authored-by: zcy <congyao.zheng@datadoghq.com>
Motivation
We want to add a field to indicate from which source the action names are generated.
Changes
Add a
name_source
field in@_dd.action
objectTesting
I have gone over the contributing documentation.