✨ [RUM-6956] Add name source to @_dd.action #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
reviewed
Nov 18, 2024
schemas/rum/action-schema.json
Outdated
| }, | ||
| "name_source": { | ||
| "type": "string", | ||
| "description": "Action name computing source", |
There was a problem hiding this comment.
Note
Can we make the description a bit clearer as to what this attribute is for ?
Also was there any investigation of what enum values might be needed in the Mobile SDKs ?
There was a problem hiding this comment.
Yes. I will add a clearer description. The enum types are discussed in this RFC. This feature is experimental. We could also leave it a non-enum string as it is readOnly: false. Wdyt?
There was a problem hiding this comment.
I think it maks sense to have an enum, I'll ask Mobile engineers working on SR privacy to take a look and add any missing value we might need.
cy-moi
force-pushed
the
congyao/RUM-6956-add-action-name-source
branch
from
1f14c03 to
4bb1452
Compare
BenoitZugmeyer
approved these changes
Nov 19, 2024
xgouchet
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
name_sourcefield to@_dd.actionrelated to PR DataDog/browser-sdk#3115