-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-6322] Use window.open observable #3215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 286 287 +1
Lines 7771 7774 +3
Branches 1754 1754
=======================================
+ Hits 7253 7256 +3
Misses 518 518 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
10be4bd
to
0c97fdc
Compare
Co-authored-by: Thomas Lebeau <thomas.lebeau@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some nits below:
`) | ||
.run(async () => { | ||
await withBrowserLogs((logs) => { | ||
// A failing test would have a log with message "Uncaught RangeError: Maximum call stack size exceeded" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should link to a Jira ticket or something with the historical context around this issue.
Motivation
window.open
instrumentation/de-instrumentation in actions collection is stacking instrumented method.Changes
Instrument
window.open
only once when SDK is loading and use an observable to listen to calls.Testing
I have gone over the contributing documentation.