Automatic click user action collection #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/click-user-action
branch
from
d2a6760 to
f6174ed
Compare
BenoitZugmeyer
force-pushed
the
benoit/click-user-action
branch
from
f6174ed to
8c3771b
Compare
This commit addresses typings issues in the E2E tests to make tests more easier to write. RUM events returned by the server are not the same as those used accross the sdk. Typically, their properties are snake cased instead of camelCased. To improve this, we remove the SDK types usages, and replace them by custom types used only for those tests. A bit of typings are repeated, but it makes the DX more easier. Those types can be adjusted at will for the tests needs. Some grobal types have been adjusted too.
BenoitZugmeyer
force-pushed
the
benoit/click-user-action
branch
from
8c3771b to
1a4fe75
Compare
And associated variable names
BenoitZugmeyer
force-pushed
the
benoit/click-user-action
branch
from
1a4fe75 to
2312a55
Compare
bcaudan
reviewed
Apr 6, 2020
bcaudan
reviewed
Apr 6, 2020
bcaudan
reviewed
Apr 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 29 29
Lines 1621 1621
Branches 333 333
=======================================
Hits 1409 1409
Misses 212 212 Continue to review full report at Codecov.
|
Having two separate variables makes things more explicit
bcaudan
reviewed
Apr 7, 2020
BenoitZugmeyer
added a commit
that referenced
this pull request
Apr 8, 2020
This also removes the LongTask startTime property that was added inadvertently by #338
BenoitZugmeyer
added a commit
that referenced
this pull request
Apr 8, 2020
* 🐛 [RUM] user action duration should be in ns * [RUM] change userActionId to userAction.id * 🏷 [RUM] adjust types This also removes the LongTask startTime property that was added inadvertently by #338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the automatic click user action collection based on the previous POC.
For now, it is behind the
collect-user-actionsfeature flag.Future steps will include:
user_action.measures)