Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM] User action collection adjustements #346

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

BenoitZugmeyer
Copy link
Member

After a few tests on staging, user actions needs two adjustments:

  • change the data model so user_action_id becomes user_action.id on all RUM events
  • convert the duration in nanoseconds to be in line with other rum events

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 8, 2020 15:18
}

export interface RumErrorEvent {
date: number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, could you also make this change:

function trackErrors(lifeCycle: LifeCycle, addRumEvent: (event: RumErrorEvent) => void) {

This also removes the LongTask startTime property that was added
inadvertently by #338
@codecov-io
Copy link

Codecov Report

Merging #346 into master will increase coverage by 0.11%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   87.25%   87.37%   +0.11%     
==========================================
  Files          29       29              
  Lines        1671     1671              
  Branches      344      344              
==========================================
+ Hits         1458     1460       +2     
+ Misses        213      211       -2     
Impacted Files Coverage Δ
packages/rum/src/rum.ts 88.04% <50.00%> (+2.17%) ⬆️
packages/rum/src/userActionCollection.ts 98.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa49ad9...8443d7d. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 653bb0e into master Apr 8, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/user-action-collection-adjustements branch April 8, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants