Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-974] use user-agent to detect synthetics sessions #969

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 2, 2021

Motivation

Synthetics browser tests now add a specific value in the user agent to ease the identification, cf doc

Changes

  • Check user agent instead of global variable
  • Check only once

Testing

unit test
Need to check on staging


I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #969 (4feb81d) into main (cb113a5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files          83       83           
  Lines        3866     3867    +1     
  Branches      857      857           
=======================================
+ Hits         3444     3445    +1     
  Misses        422      422           
Impacted Files Coverage Δ
packages/rum-core/src/domain/assembly.ts 97.87% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb113a5...4feb81d. Read the comment docs.

@bcaudan bcaudan marked this pull request as ready for review August 2, 2021 15:51
@bcaudan bcaudan requested a review from a team as a code owner August 2, 2021 15:51
@BenoitZugmeyer
Copy link
Member

Code looks good. Could we have a small unit-test for this?

@bcaudan bcaudan merged commit 707163a into main Aug 3, 2021
@bcaudan bcaudan deleted the bcaudan/s8-user-agent branch August 3, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants