🐛[RUMF-990] restore global check to detect synthetics sessions #997
Conversation
| @@ -88,7 +90,8 @@ export function startRumAssembly( | |||
| date: timeStampNow(), | |||
| service: configuration.service, | |||
| session: { | |||
| type: sessionType, | |||
| // must be computed on each event because synthetics instrumentation can be done after sdk execution | |||
There was a problem hiding this comment.
Does that mean that if the first events happen before the synthetics instrumentation, they will be sent with the wrong session type?
There was a problem hiding this comment.
yes, it was the previous behavior
There was a problem hiding this comment.
We currently have a RFC that tries to relate RUM events to Synthetics tests, I think some solutions from that RFC could be used for this use case too. In particular, I like the idea of using a Set-Cookie header to pass data from Synthetics to the SDK. So we could set the session type based on the presence of a cookie.
Do you think it worth exploring that solution? may be as a follow-up to this PR?
There was a problem hiding this comment.
We already discussed this topic during our daily yesterday, the solution describe in the RFC could indeed make the synthetics sessions detection more reliable. However, since this solution is not yet available, the goal of this PR is to fix the issue introduced with the previous change.
Motivation
User agent used by synthetics can be overwritten by the customer. So user agent check is not enough.
Changes
Restore check on global.
Previous PR:
#969
Testing
unit
I have gone over the contributing documentation.