Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗ [RUMF-970] experiment with buffered PerformanceObserver #972

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 3, 2021

Motivation

Try to retrieve largest-contentful-paint, first-input and layout-shift values that could have been emitted before SDK init.

Changes

behind 'buffered-perf' flag, create one buffered observer for each experimental type.

Testing

locally


I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #972 (fd6d7ce) into main (4dfbddd) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   89.08%   88.92%   -0.17%     
==========================================
  Files          83       83              
  Lines        3867     3874       +7     
  Branches      857      858       +1     
==========================================
  Hits         3445     3445              
- Misses        422      429       +7     
Impacted Files Coverage Δ
...ages/rum-core/src/browser/performanceCollection.ts 13.86% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfbddd...fd6d7ce. Read the comment docs.

@bcaudan bcaudan marked this pull request as ready for review August 3, 2021 14:22
@bcaudan bcaudan requested a review from a team as a code owner August 3, 2021 14:22
@bcaudan bcaudan merged commit 310fc2e into main Aug 4, 2021
@bcaudan bcaudan deleted the bcaudan/perf-observer-buffered branch August 4, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants