Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-970] enable buffered PerformanceObserver #995

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 11, 2021

Motivation

Retrieve largest-contentful-paint, first-input and layout-shift values that could have been emitted before SDK init.

Changes

Remove 'buffered-perf' flag

related PRs:

Testing

Manual + DD app


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner August 11, 2021 15:50
@codecov-commenter
Copy link

Codecov Report

Merging #995 (2767f6b) into main (d4d05d7) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
+ Coverage   88.83%   88.87%   +0.04%     
==========================================
  Files          84       84              
  Lines        3913     3910       -3     
  Branches      866      865       -1     
==========================================
- Hits         3476     3475       -1     
+ Misses        437      435       -2     
Impacted Files Coverage Δ
...ages/rum-core/src/browser/performanceCollection.ts 14.00% <0.00%> (+0.40%) ⬆️
packages/core/src/tools/timeUtils.ts 90.90% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d05d7...2767f6b. Read the comment docs.

@bcaudan bcaudan merged commit c6b54af into main Aug 12, 2021
@bcaudan bcaudan deleted the bcaudan/buffered-perf-obs branch August 12, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants