Add a basic e2e test JMXFetch

[carlosroman]

What does this PR do?

Adds a test for JMXFetch and also the Agent command jmx list collected with-rate-metrics.

Motivation

I want to reduce the amount of manual QA we do for JMXFetch.

Describe how to test/QA your changes

Check the tests in new-e2e-aml pass.

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 50198555 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50198555 --os-family=ubuntu

Note: This applies to commit a3de71f

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3852d812-7e2d-40f7-9fdf-fb690887952e

Baseline: 677d39b
Comparison: a3de71f
Diff

Optimization Goals: ❌ Significant changes detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	pycheck_lots_of_tags	% cpu utilization	-5.72	[-9.12, -2.33]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+1.98	[-1.88, +5.85]	1	Logs
➖	quality_gate_logs	% cpu utilization	+1.73	[-1.25, +4.71]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.61	[+0.55, +0.67]	1	Logs
➖	file_tree	memory utilization	+0.59	[+0.44, +0.74]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.24	[-0.54, +1.01]	1	Logs
➖	quality_gate_idle	memory utilization	+0.19	[+0.14, +0.23]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+0.10	[-0.65, +0.85]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.08	[-0.71, +0.87]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.05	[-0.42, +0.52]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.62, +0.63]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.75, +0.77]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.80, +0.77]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.10, +0.06]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.69	[-2.42, -0.97]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-2.80	[-2.93, -2.68]	1	Logs bounds checks dashboard
✅	pycheck_lots_of_tags	% cpu utilization	-5.72	[-9.12, -2.33]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency	lost_bytes	8/10
❌	file_to_blackhole_500ms_latency	lost_bytes	8/10
❌	file_to_blackhole_100ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[carlosroman]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

[dd-devflow]

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

---

2024-11-22 10:56:38 UTC ℹ️ Gitlab pipeline started

Started pipeline #49712056

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

new-e2e-aml

  new-e2e-aml:
    after_script:
    - $CI_PROJECT_DIR/tools/ci/junit_upload.sh
    artifacts:
      expire_in: 2 weeks
      paths:
      - $E2E_OUTPUT_DIR
      - junit-*.tgz
      reports:
        annotations:
        - $EXTERNAL_LINKS_PATH
      when: always
    before_script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_e2e.tar.xz
    - mkdir -p ~/.aws
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config
      || exit $?
    - export AWS_PROFILE=agent-qa-ci
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_PRIVATE_KEY_PATH && chmod 600 $E2E_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_PRIVATE_KEY_PATH || exit $?
    - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
    - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
      || exit $?; export ARM_CLIENT_ID
    - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
      || exit $?; export ARM_CLIENT_SECRET
    - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
      || exit $?; export ARM_TENANT_ID
    - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
      || exit $?; export ARM_SUBSCRIPTION_ID
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
      || exit $?
    - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
    - inv -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
    image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
    needs:
    - go_e2e_deps
    - deploy_deb_testing-a7_x64
    - deploy_windows_testing-a7
    - qa_agent
+   - qa_agent_jmx
    - qa_dca
    rules:
    - if: $RUN_E2E_TESTS == "off"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $RUN_E2E_TESTS == "on"
      when: on_success
    - if: $CI_COMMIT_BRANCH == "main"
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: on_success
    - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
      when: on_success
    - changes:
        compare_to: main
        paths:
        - .gitlab/e2e/e2e.yml
        - test/new-e2e/pkg/**/*
        - test/new-e2e/go.mod
        - flakes.yaml
    - changes:
        compare_to: main
        paths:
        - test/new-e2e/tests/agent-metrics-logs/**/*
        - cmd/agent/subcommands/dogstatsd*/*
        - cmd/agent/subcommands/streamlogs/*
        - cmd/dogstatsd/**/*
        - comp/agent/jmxlogger/**/*
        - comp/aggregator/**/*
        - comp/collector/**/*
        - comp/core/agenttelemetry/**/*
        - comp/core/autodiscovery/providers/config_reader*.go
        - comp/core/autodiscovery/providers/file*.go
        - comp/dogstatsd/**/*
        - comp/forwarder/**/*
        - comp/logs/**/*
        - comp/serializer/compression/**/*
        - pkg/aggregator/**/*
        - pkg/collector/**/*
        - pkg/commonchecks/**/*
        - pkg/jmxfetch/**/*
        - pkg/logs/**/*
        - pkg/metrics/**/*
        - pkg/persistentcache/**/*
        - pkg/serializer/**/*
        - rtloader/**/*
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
      -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
      --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer
    stage: e2e
    tags:
    - arch:amd64
    variables:
      E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
      E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
      E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
      E2E_PIPELINE_ID: $CI_PIPELINE_ID
      E2E_PRIVATE_KEY_PATH: /tmp/agent-qa-ssh-key
      E2E_PUBLIC_KEY_PATH: /tmp/agent-qa-ssh-key.pub
      EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
      KUBERNETES_CPU_REQUEST: 6
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      SHOULD_RUN_IN_FLAKES_FINDER: 'true'
      TARGETS: ./tests/agent-metrics-logs
      TEAM: agent-metrics-logs

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

[carlosroman]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-02 11:09:27 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-12-02 12:00:23 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 23m.