Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docker image checks to make sure JMX image available and used for pipelines #1266

Merged

Conversation

carlosroman
Copy link
Contributor

@carlosroman carlosroman commented Nov 27, 2024

What does this PR do?

Added a check to make sure JMX image of the Agent is deployed by adding a new function called InternalRegistryFullImagePathExists that allows me to use a computed Docker image path. This means that tests that don't care about the JMX image won't have to rely on that job in the gitlab pipeline and we check the the image for the given test.

Also added a check on ECR to make sure we don't check for none ECR images + a unit test for parsing Docker image tags.

Which scenarios this will impact?

Docker end to end test, particularly the one created for JMXFetch here. I've temporarily bumped the version of test-infra-definitions in that PR so that I can validate the changes work.

Motivation

To run e2e tests for JMXFetch we need the Docker image with Java published.

@carlosroman carlosroman requested a review from a team as a code owner November 27, 2024 10:50
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests-fix branch from 4515ff1 to 4cb277f Compare November 27, 2024 15:25
@carlosroman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 27, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-27 16:54:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-27 20:54:50 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@carlosroman carlosroman force-pushed the carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests-fix branch 2 times, most recently from 2b7fd62 to 4a49cfb Compare November 28, 2024 12:44
@carlosroman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 12:46:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-28 16:47:00 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@carlosroman carlosroman force-pushed the carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests-fix branch from 4a49cfb to 17d2761 Compare November 28, 2024 15:11
@carlosroman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 17:13:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-28 17:33:39 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 19m.

Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding a test!

@dd-mergequeue dd-mergequeue bot merged commit 1321f02 into main Nov 28, 2024
9 checks passed
@dd-mergequeue dd-mergequeue bot deleted the carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests-fix branch November 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants