-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating docker image checks to make sure JMX image available and used for pipelines #1266
Updating docker image checks to make sure JMX image available and used for pipelines #1266
Conversation
4515ff1
to
4cb277f
Compare
/merge |
Devflow running:
|
2b7fd62
to
4a49cfb
Compare
/merge |
Devflow running:
|
4a49cfb
to
17d2761
Compare
/merge |
Devflow running:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding a test!
What does this PR do?
Added a check to make sure JMX image of the Agent is deployed by adding a new function called
InternalRegistryFullImagePathExists
that allows me to use a computed Docker image path. This means that tests that don't care about the JMX image won't have to rely on that job in the gitlab pipeline and we check the the image for the given test.Also added a check on ECR to make sure we don't check for none ECR images + a unit test for parsing Docker image tags.
Which scenarios this will impact?
Docker end to end test, particularly the one created for JMXFetch here. I've temporarily bumped the version of
test-infra-definitions
in that PR so that I can validate the changes work.Motivation
To run e2e tests for JMXFetch we need the Docker image with Java published.