Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new collect_default_jvm_metrics flag for JMXFetch #6923

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Document new collect_default_jvm_metrics flag for JMXFetch #6923

merged 4 commits into from
Dec 11, 2020

Conversation

gh123man
Copy link
Member

@gh123man gh123man commented Dec 7, 2020

What does this PR do?

Added docs for collect_default_jvm_metrics. This flag allows users to disable default jvm metrics in JMXFetch

Motivation

Goes with this PR: DataDog/jmxfetch#345

@gh123man gh123man added the [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. label Dec 7, 2020
@gh123man gh123man added this to the 7.25.0 milestone Dec 7, 2020
@gh123man gh123man requested a review from a team as a code owner December 7, 2020 15:43
@gh123man gh123man mentioned this pull request Dec 7, 2020
Merged
4 tasks
remeh
remeh approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it's matching the JMXFetch change 👍

@gh123man gh123man merged commit 82e8666 into master Dec 11, 2020
@gh123man gh123man deleted the brian/collect-default-jvm-metrics-flag branch December 11, 2020 15:16
sergei-deliveroo pushed a commit to deliveroo/datadog-agent that referenced this pull request Mar 24, 2021
@gh123man @sergei-deliveroo
Document new collect_default_jvm_metrics flag for JMXFetch (DataDog#6923
15cf0dd 
)

* update JMX docs

* release notes

* better doc string

* update docs to match integrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remeh remeh remeh approved these changes

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
[deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Milestone
7.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gh123man @truthbk @remeh